Skip to content

Commit e16d8d5

Browse files
Rollup merge of #163118 - lcnr:field_types-fixme, r=oli-obk
add `feature(field_projections)` fixme see the added fixme :> r? types
2 parents 72ccf9b + 28b5293 commit e16d8d5

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

‎compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1494,6 +1494,9 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
14941494
obligation: &PolyTraitObligation<'tcx>,
14951495
candidates: &mut SelectionCandidateSet<'tcx>,
14961496
) {
1497+
// FIXME(field_projections): We should not use `evaluate_obligation` in
1498+
// the trait solver. Doing so means we don't track overflow and cycles properly
1499+
// encountering query cycles instead.
14971500
if let ty::Adt(def, args) = obligation.predicate.self_ty().skip_binder().kind()
14981501
&& let Some(FieldInfo { base, ty, .. }) =
14991502
def.field_representing_type_info(self.tcx(), args)

0 commit comments

Comments
 (0)