fix(auth): respect user-provided auth options in createBrowserClient#167
Conversation
autoRefreshToken, detectSessionInUrl, persistSession were hardcoded, overwriting any user-provided options.auth.* values. Use nullish coalescing to fall back to defaults only when not explicitly set. Fixes supabase#108 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR addresses a bug where user-provided auth options were being ignored when creating a browser client. The Assessment against linked issues
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@mandarini could you have a look at it? thanks! |
🤖 I have created a release *beep* *boop* --- ## [0.10.1](v0.10.0...v0.10.1) (2026-04-08) ### Bug Fixes * **auth:** respect user-provided auth options in createBrowserClient ([#167](#167)) ([5f04837](5f04837)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: supabase-releaser[bot] <223506987+supabase-releaser[bot]@users.noreply.github.com>
Summary
createBrowserClienthardcodesautoRefreshToken,detectSessionInUrl, andpersistSessionafter spreadingoptions.auth, overwriting any caller-provided values??) so explicit options are respected, falling back to current defaults (isBrowser()/true) when not setFixes #108