fix(tests): relax timing assertion and increase daemon startup timeout#30
Merged
Merged
Conversation
- daemon_heartbeat_prevents_idle_shutdown: lower threshold from 800ms to 500ms — CI scheduling jitter can cause the monitor to fire earlier than expected under load. Include elapsed time in the failure message. - TestDaemon::start: increase startup timeout from 15s to 30s and poll interval from 100ms to 200ms. macOS CI runners under load can take 10+ seconds for hyperd to start, causing spurious timeout failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon_heartbeat_prevents_idle_shutdown: lower threshold from 800ms to 500ms — CI scheduling jitter can cause the monitor to fire earlier than expected under load. Include elapsed time in the failure message.
TestDaemon::start: increase startup timeout from 15s to 30s and poll interval from 100ms to 200ms. macOS CI runners under load can take 10+ seconds for hyperd to start, causing spurious timeout failures.