Repository navigation
fix(proto): remove unreachable InvalidBlockRange::EmptyRange - #2591
Merged
Mirko-von-Leipzig merged 2 commits intoSep 9, 2026
Merged
Mirko-von-Leipzig merged 2 commits into
Mirko-von-Leipzig merged 2 commits into
Conversation
RangeInclusive is empty exactly when start > end, which is already rejected as StartGreaterThanEnd. Drop the dead EmptyRange variant and add boundary tests for inverted, single-block, and ascending ranges.
Mirko-von-Leipzig
approved these changes
Sep 8, 2026
Collaborator
|
@kutluhaneth46 if you could fix the lint errors |
Contributor
Author
|
Fixed the clippy lint (@Mirko-von-Leipzig): moved |
Contributor
Author
|
Follow-up: the clippy |
Mirko-von-Leipzig
enabled auto-merge (squash)
September 9, 2026 05:56
Mirko-von-Leipzig
disabled auto-merge
September 9, 2026 05:56
Contributor
Author
|
Thanks for the review and merge, @Mirko-von-Leipzig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockRange::into_inclusive_rangeno longer has a deadEmptyRangebranch.RangeInclusiveis empty exactly whenstart > end, which is already reported asStartGreaterThanEnd, so theEmptyRangevariant could never be constructed.Test plan
cargo test -p miden-node-proto into_inclusive_rangeChangelog