Alternative configurable deploy excludes - #14
Closed
LeoColomb wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@LeoColomb Thanks for opening this PR, I apologize for not getting around to checking it out earlier. Could you possibly re-open this against https://github.com/10up/action-wordpress-plugin-deploy instead? I'm splitting this repo (see #21) so I'd like to move this over there and then continue the conversation :) |
Author
|
Closed in favor of 10up/action-wordpress-plugin-deploy#3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1, ref #7 and can satisfy #3
This PR aims to let the source of files to deploy be easily configurable.
If
GITHUB_TOKENis provided, the process is exactly the same.If not provided, we fallback to local files.
Using local files helps solving #3, where we can use GitHub Actions with layers.
We use
.distignoreas suggested in #1 to ignore file with rsync while letting this be configurable.The documentation may require an update, but let me know your thoughts on this first.