[bong-water-water-bong]

scripts/build-windows.sh now also builds ryzenai-server.exe (third_party/ryzenai-server, the ONNX backend from #100) and places Microsoft's ONNX Runtime GenAI 0.11.2 and ONNX Runtime 1.23.2 win-x64 DLLs (MIT, pinned, sha256-checked) beside it. 1bit.exe then serves ONNX Runtime GenAI model directories on Windows (CPU).

How it builds with llvm-mingw. Upstream is untouched:

• a wrapper project add_subdirectorys ryzenai-server and clears its MSVC-only /SUBSYSTEM:CONSOLE link flag;
• a one-line Wbemidl.h shim covers MinGW's lowercase header;
• the MinGW-built exe links Microsoft's MSVC-built onnxruntime-genai.dll through its import library.

Not fetched: DirectML. DirectML (the GPU on Windows) needs DirectML.dll, which is under Microsoft's redistributable licence rather than MIT, so the script leaves it out. docs/windows.md and docs/onnx.md say so.

Tested under Wine 11 on Strix Halo, from a clean clone (the script ran in 2 min), with neither --device nor any backend path:

• On a CPU ONNX model directory, 1bit.exe serve chose onnx, started ryzenai-server.exe beside it and answered "The capital of France is Paris." On a GGUF it started llama-server.exe on Vulkan and answered the same.
• taskkill /F /IM 1bit.exe left nothing running.
• ryzenai-server.exe alone: 61 tok/s on Qwen2.5-0.5B int4.

🤖 Generated with Claude Code

[context7]

Docs7 for 1bit-monster/engine

Result	Status	Action
Deployment	➖ Not used	—
Content review	➖ Did not run. This site has no agent runs available this month. Wait for the monthly reset or check your Docs7 plan.	—

Commit d074203

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 100 - Partially compliant Compliant requirements: Cross-builds the engine for Windows 10+ x64 on Linux Builds ryzenai-server.exe with ONNX Runtime GenAI and ONNX Runtime DLLs Includes Microsoft's ONNX Runtime GenAI 0.11.2 and ONNX Runtime 1.23.2 win-x64 DLLs Documents the build process and usage in docs/windows.md and docs/onnx.md Does not fetch DirectML as it is under Microsoft's redistributable licence Tests under Wine 11 on Strix Halo Non-compliant requirements: The PR does not explicitly state that 1bit.exe serves ONNX Runtime GenAI model directories on Windows (CPU) in the PR description or code diff Requires further human verification: Whether 1bit.exe correctly serves ONNX Runtime GenAI model directories on Windows (CPU) after the build Whether the binary correctly carries DT_RPATH $ORIGIN so ONNX Runtime GenAI's run-time dlopen finds the copy beside it

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Error Handling for Unzip Operations The unzip_to function in scripts/build-windows.sh does not check if the unzip command succeeded. If the unzip operation fails, the script will continue without error, potentially leading to missing or corrupted files needed for the build. This could cause build failures or runtime issues. unzip_to() { [ -d "$2" ] || { mkdir -p "$2.tmp" && (cd "$2.tmp" && cmake -E tar xf "$1") && mv "$2.tmp" "$2"; }; } unzip_to "$(fetch $OGA_WIN $OGA_WIN_SHA oga-win.zip)" "$work/oga-win" unzip_to "$(fetch $ORT_WIN $ORT_WIN_SHA ort-win.zip)" "$work/ort-win" Potential Race Condition in CMake Build The script builds ryzenai-server.exe using a wrapper project that modifies the CMake configuration. If multiple builds are running concurrently, there's a potential race condition in the creation of temporary directories ($work/rz-wrap, $work/rz-shim, $work/oga-root) or in the CMake build process itself. This could lead to inconsistent builds or failures. mkdir -p "$work/rz-wrap" "$work/rz-shim" "$work/oga-root" echo '#include <wbemidl.h>' > "$work/rz-shim/Wbemidl.h" cat > "$work/rz-wrap/CMakeLists.txt" <<'RZ' cmake_minimum_required(VERSION 3.20) project(ryzenai-server-mingw CXX) add_subdirectory(${RYZENAI_SERVER_SRC} rz) set_target_properties(ryzenai-server PROPERTIES LINK_FLAGS "") RZ cmake -S "$work/rz-wrap" -B "$work/rz" -DRYZENAI_SERVER_SRC="$root/third_party/ryzenai-server" \ -DCMAKE_TOOLCHAIN_FILE="$work/toolchain.cmake" -DCMAKE_BUILD_TYPE=Release -DOGA_ROOT="$work/oga-root" \ -DOGA_INCLUDE="${oga}include" -DOGA_LIB="${oga}lib/onnxruntime-genai.lib" -DCMAKE_EXE_LINKER_FLAGS=-static \ "-DCMAKE_CXX_FLAGS=-D_WIN32_WINNT=0x0A00 -I$work/rz-shim" > "$work/rz.cmake.log" cmake --build "$work/rz" -j"$jobs" > "$work/rz.build.log" 2>&1 || { tail -20 "$work/rz.build.log"; exit 1; }