Repository navigation
tests: hrx_long_prompt turns thinking off through chat_template_kwargs - #399
Conversation
llama-server ignores a top-level enable_thinking, so Qwen3 spent the probe's 16 tokens thinking and the 7K prompt returned '' on every pin. Keep the top-level field for servers that read it and add the chat_template_kwargs form llama-server honours. Measured on strixhalo during the PR #393 gate: the unmodified probe fails on both the PR and the main pins; with thinking off through the template kwargs it passes 3/3 on both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Reviewer Guide 🔍(Review updated until commit 62ff16a)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 62ff16a |
Both sides apply the same thinking-off fix (chat_template_kwargs enable_thinking False); #399 added it on main, this branch added it too. Keep this branch's explanatory comment; the test code is otherwise identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tests/hrx_long_prompt.pysendsenable_thinking: falseat the top level of the request. llama-server ignores that field, so Qwen3 spends the probe's 16 tokens thinking (finish=length) and the 7K-token prompt returns''on every pin. The probe can't serve as a gate in that state.This keeps the top-level field and adds
chat_template_kwargs: {"enable_thinking": false}, which llama-server honours, in both requests.Evidence from the PR #393 gate on strixhalo, 2026-10-12, Qwen3-0.6B on HRX0:
--chat-template-kwargs '{"enable_thinking":false}': the probe passes 3/3 on both.tests/hrx_long_prompt_test.pypasses.🤖 Generated with Claude Code