Repository navigation
docs: mark the two never-measured #315 cells as unmeasured - #578
Merged
Merged
Conversation
The #315 entry's gaps table listed the GLM throughput cell and the forced-eviction intervention cell with a reason but no result, which reads as if both had been run and were merely uninteresting. They never ran, and the reasons were stale: the box has been up since the reboot, and a GPU hold is not this lane's to take while the leaderboard and kernel lanes hold the device. - GLM throughput: "not measured", and what would close it is now stated as "not yet measured - needs one llama-bench hold", with the exact command. - the intervention cell: "not measured" (the #315 regime needs ~100 GiB of GTT with four GLM-4.7-Flash neighbours, i.e. the services-off window the owner gates, and no such window has opened), closing note "not yet measured - needs the owner's services-off window". - the entry's own status line still said the docs were waiting in PR #518; they are on main. Docs only, no behaviour change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PR Reviewer Guide 🔍(Review updated until commit 7e79ca4)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 7e79ca4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cells of the #315 record were never measured, and the gaps table gave them a reason but no result, which reads as
"measured, nothing to report". This marks both explicitly and replaces the stale reasons.
llama-benchrun"llama-benchhold" plus the exact command (llama-bench -m GLM-4.7-Flash-Q4_K_M.gguf -dev HRX0 -ngl 99 -fa on -p 512,2048 -n 128 -r 3)~/wt/evictonly) re-run with the fixBoth reasons had gone stale in a way that mattered: the box has been up since the reboot, and the GPU is held by the
leaderboard and kernel lanes, not by a crash. Marking them unmeasured is the honest state, and it keeps the two cells
from being read as passing evidence for a closed entry.
Also corrected in the same file: the entry's closing status still said the documentation was "waiting in PR #518"; it is
on
main.Docs only — no code, no behaviour change,
KNOWN-ISSUES.mdalone.🤖 Generated with Claude Code