Repository navigation
build: C++26 only where the compiler offers it; older toolchains keep C++17 - #92
Merged
Merged
Conversation
… C++17 CI's GNU toolchain has no CXX26 dialect (FindOpenMP try_compile failed), so the standard follows CMAKE_CXX_COMPILE_FEATURES: 26 with amdclang 23 / g++ 15, 17 elsewhere. The source fixes are standard-neutral. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
bong-water-water-bong
merged commit Oct 5, 2026
ebe1662
into
1bit/hrx-vulkan-patched
5 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #91. GitHub's Ubuntu runner has a GCC without a C++26 dialect, so
FindOpenMP's try_compile failed at configure ("requires the language dialect CXX26 … the current compiler GNU does not support this") and the Server / CI (cpu) workflows went red on the fork.The standard now follows
CMAKE_CXX_COMPILE_FEATURES: 26 wherecxx_std_26is offered (amdclang 23 from TheRock and g++ 15 both report it — checked), 17 elsewhere. The #91 source fixes are standard-neutral, so nothing else changes.CMAKE_CXX_SCAN_FOR_MODULESstays OFF.🤖 Generated with Claude Code