Repository navigation
Conversation
…aves #644 records the newest manifest revision that exists, walking up from manifest.json, and no longer trusts latest.json. The SQL spec still served only manifest.r2.json behind a latest.json pointer, so the walk stopped at the missing manifest.json and sql (4/6) has failed on main since. It now serves manifest.json and r2 behind a stale latest.json naming the first, which also fails against the service from before #644.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql (4/6)has failed on main since #644, and any PR whose CI runs after it inherits the failure (api#639). #644 records the newest manifest revision that exists, walking up frommanifest.json, and ignoreslatest.json.test/map-asset-builds.spec.tsstill served onlymanifest.r2.jsonbehind alatest.jsonpointer, so the walk stopped at the missingmanifest.jsonand the build recorded no manifest.manifest.jsonandmanifest.r2.json, behind a stalelatest.jsonthat still names the first, the edge-cache case bug: a map-asset run records the manifest revision it published, not what a cached latest.json still names #644 is about. It expects r2.