Repository navigation
feature: map assets are built for every seeded map and any other map some mode enables, so prophunt overlays are skipped - #648
Merged
Conversation
lukepolo
force-pushed
the
feature/map-assets-enabled-maps
branch
from
October 16, 2026 16:45
65053b3 to
20970ee
Compare
lukepolo
changed the title
…some mode enables, so prophunt overlays are skipped
lukepolo
force-pushed
the
feature/map-assets-enabled-maps
branch
from
October 16, 2026 16:51
20970ee to
24d620c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map-assets job built every row in
maps, including the prophunt overlays (disabled in every mode, only loaded by public-server rotations) and soft-deleted maps. Builds run only on 5stack.gg and every instance reads them, so 5stack.gg's own mode toggles must not decide the seeded maps.maps.seededcolumn (migration);hasura/enums/maps.sqlsets it on every mode row of a map it ships and clears it on maps it stops shippingknownMapsbuildsseeded OR (enabled AND deleted_at IS NULL), and prefers an enabled row's workshop id