Repository navigation
upcoming: [DI-21842] - Added capability to toggle dots in AreaChart & show generated x-axis ticks - #76
Conversation
| ariaLabel, | ||
| connectNulls, | ||
| data, | ||
| dotRadius = 3, |
There was a problem hiding this comment.
that's the default value for everyone, and as for our case I've discussed with Kiran & seem 1.5 is fine for us, that we will pass as prop. 3 is the default dot radius of recharts so I kept it as it is
There was a problem hiding this comment.
3 is actually looks cluttered for DBaaS kind of data where we have multiple series with too granular data of 1 min.
| return `${value}`; | ||
| }; | ||
|
|
||
| export const generate12HourTicks = (data: any[], timezone: string) => { |
There was a problem hiding this comment.
this method is created by Jaalah only, & any is there because AreaChart component does not have any type defined for the data
There was a problem hiding this comment.
this thing was discussed here
There was a problem hiding this comment.
Let's leave a code comment regarding the any[] for future removal based on what was said previously
There was a problem hiding this comment.
In fact, I wouldn't mind actually pulling in the dependency we discussed and making the change with this small PR
| areas={areas} | ||
| ariaLabel={ariaLabel ? ariaLabel : ''} | ||
| data={data} | ||
| dotRadius={1.5} |
There was a problem hiding this comment.
sorry, I take back my previous comment, is 1.5 still okay
There was a problem hiding this comment.
yes for graph with lots of plots, 1.5 was looking much cleaner compared to 2.
There was a problem hiding this comment.
I agree 1.5 looks better when we analyzed.
4 participants
Description 📝
Highlight the Pull Request's context and intentions.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.With Date Scale
With Time Scale
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>Commit Types:
feat: New feature for the user (not a part of the code, or ci, ...).fix: Bugfix for the user (not a fix to build something, ...).change: Modifying an existing visual UI instance. Such as a component or a feature.refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test: New tests or changes to existing tests. Does not change the production code.upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history