fix(testing): add CPU execution flags and standardize E2E checkpoint conversion tests - #4886
Merged
Merged
Conversation
RexBearIU
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 14, 2026 04:47
There was a problem hiding this comment.
Code Review
This pull request updates several end-to-end TPU test scripts to download pre-computed golden logits from Google Cloud Storage instead of generating them on the fly or running Hugging Face models. It also standardizes the test execution by adding hardware=cpu and skip_jax_distributed_system=True parameters. The reviewer suggests using [ ! -s ... ] instead of [ ! -f ... ] when checking for the downloaded logit files to robustly handle potentially empty files from interrupted downloads.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 tasks
RexBearIU
force-pushed
the
jackyf/fix-e2e-hf-flags
branch
from
August 14, 2026 10:15
32c4b08 to
ad289d1
Compare
RexBearIU
force-pushed
the
jackyf/fix-e2e-hf-flags
branch
from
August 14, 2026 11:27
ad289d1 to
80b202d
Compare
RexBearIU
force-pushed
the
jackyf/fix-e2e-hf-flags
branch
2 times, most recently
from
August 14, 2026 13:23
2965137 to
3d7a332
Compare
dipannita08
approved these changes
Aug 14, 2026
…conversion tests - Add missing hardware=cpu and skip_jax_distributed_system=True flags to E2E shell scripts for consistent CPU execution. - Adjust max_kl_div threshold to 0.10 for Gemma 4 26B and tighten Qwen3-VL 2B threshold to 0.03.
RexBearIU
force-pushed
the
jackyf/fix-e2e-hf-flags
branch
from
August 14, 2026 16:38
3d7a332 to
4b5761c
Compare
SurbhiJainUSC
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the E2E Hugging Face checkpoint conversion test suite when executed in CPU environments:
Key Changes
CPU Execution Flags:
hardware=cpuandskip_jax_distributed_system=Trueacross the conversion test scripts (gemma4,gpt-oss,llama3.1,qwen3,qwen3-vl).Threshold Alignment:
gemma4-26b: Set--max_kl_div=0.10to account for MoE router boundary sensitivity and 256k vocabulary BF16 tail accumulation on long sequences (peak single-token KL is0.082, top tokens identical).qwen3-vl-2b: Tightened--max_kl_div=0.03.Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.