Update sync standby names to include choose keyword - #462
Merged
Conversation
gclough
requested changes
Jan 16, 2020
gclough
left a comment
gclough
left a comment
Collaborator
There was a problem hiding this comment.
Indeed. This parameter change was introduced in v10, and is correctly in the template for that version. Your patch currently fixes v12, but has missed v11. Could you make the same change in v11, and then I can merge it?
This copies the logic to render the string from the pg-10 template.
Contributor
Author
|
@gclough We never merged this! |
gclough
approved these changes
Mar 6, 2020
robustq
pushed a commit
to robustq/postgresql
that referenced
this pull request
Feb 25, 2021
Update sync standby names to include choose keyword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this file (I haven't checked all the others, except pg-10), the choose_sync var wasn't being specified.
This copies the logic to render the string from the pg-10 template.
Docs: https://www.postgresql.org/docs/12/runtime-config-replication.html#GUC-SYNCHRONOUS-STANDBY-NAMES