Skip to content

Add back vbr operations - #5523

Merged
urvangjoshi merged 4 commits into
AOMediaCodec:av2-encfrom
jingninghan:vbr2
Oct 14, 2026
Merged

Add back vbr operations#5523
urvangjoshi merged 4 commits into
AOMediaCodec:av2-encfrom
jingninghan:vbr2

Conversation

@jingninghan

@jingninghan jingninghan commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

urvangjoshi
urvangjoshi reviewed Oct 13, 2026
View reviewed changes

@urvangjoshi urvangjoshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to add back some unit tests with ::libaom_test::kTwoPassGood similar to what we originally had before https://aomedia-review.git.corp.google.com/c/aom/+/120601

That way, the 2-pass code is exercised and tested.

Comment thread CMakeLists.txt
Comment thread apps/avmenc.c Outdated
Comment thread av2/encoder/encoder.c Outdated
Comment thread av2/encoder/encoder.c
yeqing-wu
yeqing-wu reviewed Oct 13, 2026
View reviewed changes
Comment thread av2/encoder/pass2_strategy.c Outdated
@jingninghan

jingninghan commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

It will be good to add back some unit tests with ::libaom_test::kTwoPassGood similar to what we originally had before https://aomedia-review.git.corp.google.com/c/aom/+/120601

That way, the 2-pass code is exercised and tested.

Done

yeqing-wu
yeqing-wu reviewed Oct 13, 2026
View reviewed changes
Comment thread apps/avmenc.c
yeqing-wu
yeqing-wu reviewed Oct 13, 2026
View reviewed changes
Comment thread apps/avmenc.c
yeqing-wu
yeqing-wu reviewed Oct 13, 2026
View reviewed changes
Comment thread av2/encoder/pass2_strategy.c
yeqing-wu
yeqing-wu reviewed Oct 13, 2026
View reviewed changes
Comment thread av2/encoder/pass2_strategy.c
yeqing-wu
yeqing-wu approved these changes Oct 13, 2026
View reviewed changes

@yeqing-wu yeqing-wu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. One question: should we run tests to ensure that these changes won’t break the existing one-pass (VCWG CTC) pipeline?

@jingninghan

jingninghan commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, thanks. One question: should we run tests to ensure that these changes won’t break the existing one-pass (VCWG CTC) pipeline?

Yes, we will run a ctc test shortly. Still have a few unit test failure cases to resolve.

@jingninghan
jingninghan force-pushed the vbr2 branch 2 times, most recently from d75058a to 534b17b Compare October 14, 2026 18:42
urvangjoshi
urvangjoshi reviewed Oct 14, 2026
View reviewed changes
Comment thread test/av2_encoder_parms_get_to_decoder.cc Outdated
@jingninghan

jingninghan commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, thanks. One question: should we run tests to ensure that these changes won’t break the existing one-pass (VCWG CTC) pipeline?

Yes, we will run a ctc test shortly. Still have a few unit test failure cases to resolve.

Tested in speed 1, before and after the 1-pass q mode results are identical.

@urvangjoshi
urvangjoshi merged commit 8c5cdf1 into AOMediaCodec:av2-enc Oct 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@urvangjoshi urvangjoshi urvangjoshi approved these changes
@yeqing-wu yeqing-wu yeqing-wu approved these changes
@yunqingwang1 yunqingwang1 Awaiting requested review from yunqingwang1
@leolzhao leolzhao Awaiting requested review from leolzhao

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jingninghan @urvangjoshi @yeqing-wu @aom-bot