Skip to content

Symfony 4 : fix service definition and response rendering - #1019

Merged
DonCallisto merged 1 commit into
APY:masterfrom
romainguerrero:fix-symfony-4-service-usage
Jul 20, 2018
Merged

DonCallisto merged 1 commit into
APY:masterfrom
romainguerrero:fix-symfony-4-service-usage

Conversation

@romainguerrero

@romainguerrero romainguerrero commented Jul 16, 2018

Copy link
Copy Markdown
Collaborator

As Symfony 4 register services as private by default, we have to specify grid and grid.mapping.manager services as a public to be able to use them.

@romainguerrero
romainguerrero force-pushed the fix-symfony-4-service-usage branch from 7279832 to 30c769f Compare July 18, 2018 12:59
@Scuottolinx

Copy link
Copy Markdown

ping

@DonCallisto
DonCallisto merged commit dcbf867 into APY:master Jul 20, 2018
@DonCallisto

Copy link
Copy Markdown
Member

@romainguerrero thanks

@romainguerrero
romainguerrero deleted the fix-symfony-4-service-usage branch July 20, 2018 10:08
@DonCallisto DonCallisto mentioned this pull request Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants