Skip to content

Deactivate viewport user scaling - #79

Closed
ajrussellaudio wants to merge 1 commit into
ASteinheiser:masterfrom
ajrussellaudio:master
Closed

ajrussellaudio wants to merge 1 commit into
ASteinheiser:masterfrom
ajrussellaudio:master

Conversation

@ajrussellaudio

@ajrussellaudio ajrussellaudio commented May 19, 2019

Copy link
Copy Markdown
Contributor

Removes user scaling from the HTML meta tag.

This fixes #19

@ASteinheiser

Copy link
Copy Markdown
Owner

Were you able to test on Safari on an iOS device?

@ajrussellaudio

ajrussellaudio commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

I only have my own iPhone SE to test on and there are other issues with the layout on that model being tracked in #29 #12 , but yes, I've tested it in Safari and Chrome on iOS 12.2 and both double tapping and pinch to zoom are disabled. The viewport can't be zoomed at all.

@ASteinheiser

Copy link
Copy Markdown
Owner

Gotcha, sound great! Just because I've had so much trouble with this bug, I want to test this on a device as well. I seem to be having issues when testing on a simulator, so I will try on an actual device soon.

@ASteinheiser

ASteinheiser commented May 20, 2019

Copy link
Copy Markdown
Owner

@ajrussellaudio Oh and I just remembered... when I asked if you tested it, were you able to test it in the native app as well? I am not sure, but the WebView might screw with some things. I just remember this bug being really annoying. You can spin up the native app from this repo, then just change the GAME_URL in src/App.js.
I can hopefully get my hands on an iOS device soon and test on my end.

Normally, we shouldn't have to test on the native app, but this issue is only happening on iOS native app.

@ASteinheiser

Copy link
Copy Markdown
Owner

Alright @ajrussellaudio, I will merge this code. Can you actually create another PR and merge into staging instead of master? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable double-tap to zoom on iOS Safari

2 participants