chore: bump @altimateai/altimate-core to 0.5.1#925
Merged
Conversation
Update the bundled core engine dependency in `packages/opencode` from `0.4.0` to the latest published release `0.5.1`. - `packages/opencode/package.json`: bump version pin - `bun.lock`: resolved version and per-platform native binaries (`darwin-arm64`, `darwin-x64`, `linux-arm64-gnu`, `linux-x64-gnu`, `win32-x64-msvc`) move in lockstep Verified `bun install` resolves cleanly and `bun run typecheck` passes. Closes #924 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughUpdated ChangesDependency Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 10, 2026
Open
anandgupta42
added a commit
that referenced
this pull request
Jun 10, 2026
altimate-core 0.5.1 (#925) added an optional `dialect` arg to `checkEquivalence` and a `decidable` flag on `EquivalenceResult`. The dbt PR reviewer already threads a dialect end-to-end, but commit 89f77a7 had to DROP it at the engine boundary because 0.4.0 only took 3 params. This forwards it now that 0.5.1 accepts it, and consumes `decidable`. - `native/altimate-core.ts`: forward the dialect hint to `core.checkEquivalence`. Use `|| undefined` (not `??`) so the default empty `ReviewConfig.dialect` coerces to "no hint" — the engine throws on `unknown dialect ''`, and "" must mean auto-detect. - `native/sql/register.ts`: same dialect forwarding + coercion in the `sql.diff` handler. - `native/types.ts`: declare `dialect?` on `SqlDiffParams`. - `review/runner.ts`: honor the engine's authoritative `decidable` flag (`data.decidable !== false`). Strictly safer — only ever abstains more; backward-compatible when the field is absent (0.4.0 shape). Tests (all real-engine where it counts): - `altimate-core-native.test.ts`: dialect forwarding changes parse outcome, `decidable` surfaced true/false, empty-string coercion, sql.diff. - `review-equivalence-e2e.test.ts`: full `runReview` pipeline → real engine — non-equivalent caught, equivalent stays silent, identical skipped, projection change caught, and the default empty-string-dialect path still decides (regression guard). - `review-runner.test.ts`: runner honors decidable=false / true / absent. Verified: `bun run typecheck` clean, marker check clean, full new-test suite green. Reviewed via multi-model consensus (Gemini independently caught the empty-string dialect throw, now fixed + guarded). The pre-existing sibling sites (`columnLineage`/`formatSql`/etc.) share the empty-string fragility but are protected by `run.ts` resolving the dialect first; tracked separately in #927. Closes #926 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps the bundled
@altimateai/altimate-coreengine dependency inpackages/opencodefrom0.4.0to the latest published release0.5.1.packages/opencode/package.json— version pin0.4.0→0.5.1bun.lock— resolved version plus the five per-platform native binaries (darwin-arm64,darwin-x64,linux-arm64-gnu,linux-x64-gnu,win32-x64-msvc) move in lockstepThe transitive
@altimateai/altimate-core@0.1.6pulled in by@altimateai/dbt-integrationis intentionally left unchanged.Type of change
Issue for this PR
Closes #924
How did you verify your code works?
bun installresolves cleanly and rewrites the lockfile to0.5.1across all platformsbun run typecheck(tsgo --noEmit) passes inpackages/opencodewith the new versionChecklist
Summary by cubic
Upgrades
@altimateai/altimate-coreinpackages/opencodefrom 0.4.0 to 0.5.1 to pick up the latest engine fixes. Build and typechecks pass.packages/opencode/package.jsonto0.5.1.bun.lock, including per-platform binaries (darwin-arm64,darwin-x64,linux-arm64-gnu,linux-x64-gnu,win32-x64-msvc).@altimateai/altimate-core@0.1.6via@altimateai/dbt-integrationunchanged.Written for commit be597f7. Summary will update on new commits.
Summary by CodeRabbit