Skip to content

Antalya 26.3 - Review play.html - #1719

Merged
strtgbb merged 2 commits into
antalya-26.3from
fix-play-css
May 7, 2026
Merged

Antalya 26.3 - Review play.html#1719
strtgbb merged 2 commits into
antalya-26.3from
fix-play-css

Conversation

@strtgbb

@strtgbb strtgbb commented May 1, 2026

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Improvement

Changes

  • Fix running-query favicon not turning grey
  • Restore consistent button text styling in the light theme by defining the missing --button-text-color token in :root.
  • Make the copy and download controls proper button elements, preserving their appearance while restoring native keyboard focus and activation behavior.
  • Restore the logo ® size after the graph SVG styles were moved into a shadow DOM, fixing the symbol rendering larger than intended and getting clipped.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Workflow [PR], commit [65fa32a]

@strtgbb
strtgbb merged commit f3189db into antalya-26.3 May 7, 2026
266 of 305 checks passed
@CarlosFelipeOR

Copy link
Copy Markdown
Collaborator

QA Verification

Verdict: passed, with a follow-up accessibility issue found (tracked in #1823).

Verified the 4 main points covered by this PR:

1. Running-query favicon state

  • Before the fix, the browser tab favicon did not change to gray while a query was running.
  • After the fix, the favicon turns gray during query execution and returns to normal once the query finishes.

2. Light theme button text style

  • Button labels in the light theme are visible and consistent.
  • No visual regression observed compared to the previous version.

3. Copy/Download controls as keyboard-accessible buttons

  • The main Copy and Download buttons can be reached with Tab and activated with Enter/Space.
  • Mouse interaction continues to work as expected.

4. Altinity logo ® symbol size

  • Before the fix, the ® symbol rendered too large and was clipped.
  • After the fix, the ® symbol size renders correctly.

Follow-up: a separate accessibility issue was found in the Download dialog — after opening it with the keyboard, focus does not move into the dialog, so the format dropdown and the inner Download button cannot be reached using the keyboard alone. This appears to be pre-existing behavior and not a regression introduced by this PR. Tracked in #1823.

@CarlosFelipeOR CarlosFelipeOR added the verified Approved for release label May 21, 2026
@svb-alt svb-alt added the port-everywhere PRs that must be ported to every other version branch label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

antalya antalya-26.3 antalya-26.3.10.20001 port-everywhere PRs that must be ported to every other version branch verified Approved for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants