Stable 25.8: Backports of #88490 and #89999 - #2094
Merged
Merged
Conversation
…tion-for-non-append-supporting-disks Not support transaction for tables with disks which do not support writing with append.
ianton-ru
previously approved these changes
Jul 21, 2026
Check if encrypted disks support writing with append
CarlosFelipeOR
force-pushed
the
backport/stable-25.8/89999
branch
from
July 21, 2026 13:32
dfa8dc4 to
f4addda
Compare
Collaborator
Author
|
CI is clean. The only failing test is |
Collaborator
|
No need to port this to Antalya 25.8, it has already been handled by #1475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting to stable-25.8 because this crash is currently failing the Stress test on our CI (server aborts on transaction commit over non-append disks).
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
For MergeTree tables using object storage which do not support writing with append, it will not support transactions. (ClickHouse#88490 by @tuanpach)
Check if encrypted disks support writing with append (ClickHouse#89999 by @tuanpach)
Closes ClickHouse#84669
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: