Antalya 26.6: Antalya 26.3 Backport - Added test cases for s3 encoding fix - #2126
Antalya 26.6: Antalya 26.3 Backport - Added test cases for s3 encoding fix#2126zvonand wants to merge 5 commits into
Conversation
Antalya 26.3 Backport - Added test cases for s3 encoding fix
|
Local build does not have compiler errors |
|
@blau-ai fix compiler errors directly in this branch |
The gtest added by the backport called getProperFilePathFromMetadataInfo, a free function that exists in antalya-26.3 but was refactored into IcebergPathResolver::resolve() in 26.6, so the test failed to compile (use of undeclared identifier) and broke Build (amd_debug)/(arm_debug). Rewrite the four test cases against the current IcebergPathResolver API. The resolver applies the same prefix-stripping string logic, so the percent-encoding-preservation expectations are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Fixed the build failure and pushed directly to What was broken
(same error at lines 18, 27, 36 → Root causeThe backported test (from FixRewrote the four test cases against the current
Note / verificationI can't build or run tests in this environment, so the compile fix is validated by CI on this The failing |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Backport of #1516, unit/integration tests added. The original fix was in the
resolveObjectStorageForPathfunction(Utils.cpp) which was renamed/rewritten togetProperFilePathFromMetadataInfo. The tests are to make sure % encoded URLs still work in iceberg. closes #1348 (#1781 by @subkanthi).CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1781.
Documentation entry for user-facing changes
Backport of #1516, unit tests added.