Antalya 26.6: Change the interface for Iceberg inserts with the catalog - #2149
Open
zvonand wants to merge 2 commits into
Open
Antalya 26.6: Change the interface for Iceberg inserts with the catalog#2149zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1800 from Altinity/feature/antalya-26.3/ClickHouse-ClickHouse-pr-100334 Antalya 26.3: Change the interface for Iceberg inserts with the catalog # Conflicts: # src/Databases/DataLake/DatabaseDataLake.cpp # src/Storages/ObjectStorage/DataLakes/DataLakeConfiguration.h # src/TableFunctions/TableFunctionObjectStorage.cpp # tests/integration/test_database_glue/test.py # tests/integration/test_database_iceberg/test.py
antalya-26.6 already carries the equivalent of every change in #1800 (public DatabaseDataLake::getCatalog, getCatalog(ContextPtr, const StorageID &) signature, the DatabaseCatalog-based catalog lookup with the deprecated-settings check, no catalog passed from table functions, and the settings= kwargs form in the integration tests), so each conflict hunk is pure base-branch divergence and 'ours' is kept: lazy initialize()/getCatalog split in DatabaseDataLake, StorageObjectStorageCluster ctor arity in TableFunctionObjectStorage, the StorageIcebergConfiguration block and minio1:9001 / DataLakeCatalog / eager 'Unspecified catalog type' expectations in the tests.
zvonand
added
releasy
zvonand
added
the
forwardport
|
Is it possible to run integration tests for this pr? It is possible that need to add also changes from #1842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Change the interface for Iceberg inserts with the catalog.
Deprecate settings: storage_catalog_type, storage_aws_access_key_id, etc (ClickHouse#100334 by @scanhex12).
Cherry-picked from ClickHouse#100334.
--- (#1800 by @zvonand).
Cherry-picked from #1800.
Documentation entry for user-facing changes