Skip to content

24.3 Fix test integration/test_user_defined_object_persistence/test.py::test_persistence - #492

Merged
Enmk merged 2 commits into
customizations/24.3.11from
QueryAnalysisPass-typo
Oct 8, 2024
Merged

24.3 Fix test integration/test_user_defined_object_persistence/test.py::test_persistence#492
Enmk merged 2 commits into
customizations/24.3.11from
QueryAnalysisPass-typo

Conversation

@strtgbb

@strtgbb strtgbb commented Oct 3, 2024

Copy link
Copy Markdown
Collaborator

Fix typos in tests and QueryAnalysisPass.

Upstream has fixed this issue in 24.5+.

@altinity-robot

altinity-robot commented Oct 3, 2024

Copy link
Copy Markdown
Collaborator

This is an automated comment for commit 925f5a2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ error
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success

@Enmk Enmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase onto customizations/24.3.11

@strtgbb
strtgbb force-pushed the QueryAnalysisPass-typo branch from 4086c1a to 92b8545 Compare October 3, 2024 20:03
@strtgbb
strtgbb force-pushed the QueryAnalysisPass-typo branch from 92b8545 to 925f5a2 Compare October 3, 2024 20:08
@strtgbb
strtgbb changed the base branch from customizations/24.3.9 to customizations/24.3.11 October 3, 2024 20:09
@strtgbb
strtgbb requested a review from Enmk October 4, 2024 13:07

@Enmk Enmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see whats up with the tests on CI/CD

@Enmk

Enmk commented Oct 4, 2024

Copy link
Copy Markdown
Member

Closing to re-open later and retrigger CI/CD

@Enmk Enmk closed this Oct 4, 2024
@Enmk Enmk reopened this Oct 4, 2024
@strtgbb

strtgbb commented Oct 7, 2024

Copy link
Copy Markdown
Collaborator Author

Is this superseded by #493 ?

@Enmk

Enmk commented Oct 8, 2024

Copy link
Copy Markdown
Member

Is this superseded by #493 ?

not quite, it started as parallel work, perhaps I should just revert similar changes int #493

@Enmk
Enmk merged commit d48e781 into customizations/24.3.11 Oct 8, 2024
@strtgbb
strtgbb deleted the QueryAnalysisPass-typo branch March 8, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants