Skip to content

Remove obsolete variable runtime seams left after #447 phase 1 #460

Description

@BorisTyshkevich

Found while shipping #447 phase 1. Removing the curated-filter model left several exported fields and methods with no production consumer. This issue removes only seams that remain obsolete after #447 phase 2 settles the variable runtime.

Candidate removals

  • FilterBarHandle.updateStatus
  • FieldStatus
  • the no-op updateStatus implementation in src/ui/time-range-field.ts
  • ViewerFilterState.options when no production path populates it
  • ViewerFilterState.optionsRev when no production path advances it
  • any exported function, field or adapter seam whose only caller belonged to the removed curated-filter implementation

FilterBarHandle.updateStatus and FieldStatus currently remain covered only by the filter-bar routing test. A direct-input variable has no transient status, and ui/dashboard.ts no longer calls the method.

ViewerFilterState.options is currently always null and optionsRev is always 0, but #447 phase 2 may populate them from the batched option query. Audit them after phase 2 rather than deleting and immediately restoring them.

Compatibility boundaries

Do not remove legacy schemas or generated types merely because they describe curated filters. dashboard-v1.schema.json, the corresponding definitions in library-v2.bundle.schema.json, and DashboardFilterDefinitionV1 remain load-bearing while stored-workspace v2/v3/v4 and portable-bundle-v1 records are supported.

This issue is dead-code removal only. It must not alter persisted data, interchange compatibility or Dashboard behaviour.

Acceptance

Split from #457. Related issues: #457 and #459.

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorRestructuring without user-facing behavior change

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions