fix: give error toasts a 30s auto-dismiss instead of 1.6s - #508
Merged
Conversation
flashToast used the same short default duration for every message, so a failed open/import/save (marked with the app's established '✕ ' prefix) could disappear before the user finished reading it, let alone copied the text for a bug report. Error-prefixed toasts now default to 30s; plain informational toasts are unchanged, and an explicit `duration` still overrides either default. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sMwR4BHM85MExSBYXzTYj
Most panel queries declare their from/to (or start/end, from_time/to_time, start_time/end_time) variables directly in a required WHERE clause, never behind an optional /*[ ... ]*/ block, so a never-persisted time-range bound starting genuinely empty blocked every one of that pair's panels on first load until the user set a range by hand. A resolvable time-range pair with no committed value yet now seeds to a real, active "-1d" -> "now" range instead. Any already-persisted value (even a deliberately cleared one) is untouched -- this only changes the very first, never-seeded state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sMwR4BHM85MExSBYXzTYj
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flashToastused the same 1.6s auto-dismiss for every message, so a failed open/import/save (the app marks these with a leading✕) could vanish before it was read, let alone copied for a bug report.✕ …) now default to a 30s auto-dismiss; plain informational/success toasts are unchanged (still 1.6s). An explicitdurationpassed by the caller still wins over either default.Test plan
npx tsc --noEmitTZ=America/New_York npx vitest run --config tests/vitest.config.ts --coverage(5938/5938 passing, 100% per-file thresholds held)node build/check-boundaries.mjs🤖 Generated with Claude Code
https://claude.ai/code/session_011sMwR4BHM85MExSBYXzTYj