Publish sql.html to GitHub Pages at docs.altinity.com/altinity-sql-browser/ - #511
Merged
Merged
Conversation
…owser/ Mirrors the built sql.html + a demo config.json (Antalya/github.demo, 2 Google SSO + 2 demo/demo hosts) onto docs/ so docs.altinity.com/altinity-sql-browser/sql.html loads the real app, no ClickHouse-served deployment required. release.yml now republishes on every tagged release; this backfills the current v0.6.4 build so the page is live immediately. Fixes loadConfigDoc to resolve config.json from the containing directory when basePath is a static filename (sql.html) rather than a route (/sql) - the existing code appended /config.json straight onto the URL, which only happened to work because the ClickHouse route has no file extension. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017E2cHgYTiobxSJLnCxgCPj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql.html+ a demodocs/config.json(Antalya/github.demo clusters: 2 Google SSO + 2 demo/demo saved connections) ontodocs/, sohttps://docs.altinity.com/altinity-sql-browser/sql.htmlloads the real app without any ClickHouse-served deployment. GitHub Pages already serves this repo'smainbranch/docsat that domain.docs/sql.htmlfrom the currentv0.6.4release so the page is live as soon as this merges;release.ymlnow republishes it (last step, after the Helm push) on every future tagged release.loadConfigDoc(src/net/oauth-config.ts) to resolveconfig.jsonfrom the containing directory whenbasePathis a static filename (e.g.sql.html) rather than a route (e.g./sql) — the previous code appended/config.jsonstraight onto the URL, which only happened to work because the ClickHouse route has no file extension. Verified live in a headless browser against a static file server at a nested.../sql.htmlpath: config loads and all 4 saved connections render.CHANGELOG.md[Unreleased]entry, and a short note indocs/ASSET-DISTRIBUTION.mdclarifying this GitHub Pages mirror is a separate, unauthenticated demo channel from the cluster-serving problem that doc covers.Manual follow-up (outside this PR)
The "Google SSO" login buttons will 400 (
redirect_uri_mismatch) fromdocs.altinity.comuntil someone with Google Cloud Console access addshttps://docs.altinity.com/altinity-sql-browser/sql.htmlas an authorized redirect URI on both Google OAuth clients referenced indocs/config.json. The demo/demo basic-auth entries work immediately without this.Test plan
npm test— full coverage gate passes (100% statements/functions/lines; newoauth-config.test.tscase for the static-filebasePath)npx tsc --noEmitpassesnpm run buildproducesdist/sql.htmlnpm run local's/sqlroute still resolvesconfig.jsoncorrectlydist/sql.html+docs/config.jsonfrom a static server at a nested.../sql.htmlpath, confirmed via Playwright the login screen renders all 4 saved connections with no failed requestshttps://docs.altinity.com/altinity-sql-browser/sql.htmland.../config.jsonare live (GitHub Pages rebuild is automatic on push tomain)🤖 Generated with Claude Code
https://claude.ai/code/session_017E2cHgYTiobxSJLnCxgCPj