refactor(#429): remove obsolete repair planner (phase 6) - #514
Merged
Conversation
Delete the unused saved-query mutation planner and its dedicated test suite now that ownership-safe Panel and Dashboard actions are the supported cascading delete paths. Preserve fail-closed whole-workspace validation and replace the dead planner coverage with production-path tests across non-current Dashboards. Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: unavailable (OpenAI Codex)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Part of #429
Closes #500
Phase 6 records the final remove planner decision from #500. The unused
saved-query repair planner and its dedicated tests are deleted now that #494's
ownership-safe Panel and Dashboard trash actions are the supported cascading
delete paths. Library deletion and saved-query edits continue to use strict
whole-workspace validation and fail atomically rather than guessing repairs.
Replacement production-path coverage proves that:
trash controls;
tab while preserving every Dashboard;
rejected with state byte-identical; and
source or tests unnoticed.
Acceptance claimed from #429: the repair-planner disposition only. The
#438-gated Open-in-Dashboard focus work remains outside this phase.
Verification
npm test— 183 files / 6,089 tests; TypeScript clean; 100% statements andlines
npm run build—dist/sql.htmlbuilt successfullynpm run test:e2e -- --project=chromium --project=webkit --workers=1—341 passed, 1 skipped
latestmakes all three non-current-Dashboard safety tests fail
finding was addressed
Checklist
npm testpasses (the per-file coverage gate is non-negotiable)npm run buildsucceeds (single-filedist/sql.html)src/core/, network insrc/net/(injected fetch), DOM insrc/ui/CHANGELOG.md([Unreleased]) updated if behavior or the deployed surface changed