Skip to content

refactor(#429): remove obsolete repair planner (phase 6) - #514

Merged
BorisTyshkevich merged 1 commit into
mainfrom
refactor/remove-repair-planner-429p6
Jul 28, 2026
Merged

refactor(#429): remove obsolete repair planner (phase 6)#514
BorisTyshkevich merged 1 commit into
mainfrom
refactor/remove-repair-planner-429p6

Conversation

@BorisTyshkevich

Copy link
Copy Markdown
Collaborator

What & why

Part of #429
Closes #500

Phase 6 records the final remove planner decision from #500. The unused
saved-query repair planner and its dedicated tests are deleted now that #494's
ownership-safe Panel and Dashboard trash actions are the supported cascading
delete paths. Library deletion and saved-query edits continue to use strict
whole-workspace validation and fail atomically rather than guessing repairs.

Replacement production-path coverage proves that:

  • ownership on a non-current Dashboard excludes the query from Library and its
    trash controls;
  • an ordinary zero-owner Library query still deletes and reconciles its linked
    tab while preserving every Dashboard;
  • deleting or invalidating a query owned only by a non-current Dashboard is
    rejected with state byte-identical; and
  • the retired planner API and repair vocabulary cannot be reintroduced into
    source or tests unnoticed.

Acceptance claimed from #429: the repair-planner disposition only. The
#438-gated Open-in-Dashboard focus work remains outside this phase.

Verification

  • npm test — 183 files / 6,089 tests; TypeScript clean; 100% statements and
    lines
  • npm run builddist/sql.html built successfully
  • npm run test:e2e -- --project=chromium --project=webkit --workers=1
    341 passed, 1 skipped
  • sabotage check — forcing saved-query writes to ignore committed latest
    makes all three non-current-Dashboard safety tests fail
  • two independent read-only reviews — clean after the whole-collection test
    finding was addressed

Checklist

Delete the unused saved-query mutation planner and its dedicated test suite now that ownership-safe Panel and Dashboard actions are the supported cascading delete paths. Preserve fail-closed whole-workspace validation and replace the dead planner coverage with production-path tests across non-current Dashboards.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

Claude-Session: unavailable (OpenAI Codex)
@BorisTyshkevich
BorisTyshkevich merged commit ce89ef2 into main Jul 28, 2026
7 checks passed
@BorisTyshkevich
BorisTyshkevich deleted the refactor/remove-repair-planner-429p6 branch August 6, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove obsolete saved-query repair planner and retire #429 repair phase

1 participant