Remove obsolete dashboard layout code - #517
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dashLayout/dashColspreference and its legacy Dashboard helpers.onRaw, the ignored fourthbuildCardModelparameter, and the unused Spec-schema import.Why
The legacy layout system was superseded by the workspace-backed Dashboard layout model. The remaining surface could no longer affect production behavior and left stale state, CSS, and API contracts behind. The mobile CSS targeted a class the splitter did not carry.
Impact
No runtime Dashboard behavior changes. Old
asb:dashLayout/asb:dashColslocalStorage values are simply ignored. In single-pane mobile editor view, the splitter no longer leaves a visible resize row.The PNG finding was not actioned:
docs/assets/imgis referenced by live project documentation, anddocs/ui-snapshotsis the documented versioned design-review archive.Validation
npm test— 6,079 tests passed; coverage gate met (100% statements/lines).npx playwright test tests/e2e/tile-open-workbench.spec.js— 34 passed, 2 skipped (browser-platform skips); includes the mobile splitter regression check.npm run build— succeeded.