Skip to content

Fix nightly E2E authentication fixture - #531

Merged
BorisTyshkevich merged 1 commit into
mainfrom
agent/fix-nightly-e2e-auth-fixture
Jul 29, 2026
Merged

Fix nightly E2E authentication fixture#531
BorisTyshkevich merged 1 commit into
mainfrom
agent/fix-nightly-e2e-auth-fixture

Conversation

@BorisTyshkevich

Copy link
Copy Markdown
Collaborator

Summary

  • initialize the full-surface Dashboard E2E fixture through the app-owned authenticated execution lifecycle
  • keep hover-revealed Dashboard row controls in the keyboard focus order
  • make the cross-browser E2E assertion focus the direct action rather than assuming an engine-specific adjacent tab position

Root cause

The nightly scheduled browser run surfaced a fixture that replaced public execution-scope accessors, while renderApp() reads its private lifecycle state to decide whether the blocking authentication overlay starts hidden. The overlay therefore intercepted every Dashboard interaction. The same repair exposed that display: none controls could not be reached by keyboard in WebKit.

Validation

  • npx playwright test tests/e2e/tile-open-workbench.spec.js (37 passed, 2 expected skips)
  • npm test
  • npm run build

@BorisTyshkevich
BorisTyshkevich marked this pull request as ready for review July 29, 2026 07:24
@BorisTyshkevich
BorisTyshkevich merged commit 11f466f into main Jul 29, 2026
14 checks passed
@BorisTyshkevich
BorisTyshkevich deleted the agent/fix-nightly-e2e-auth-fixture branch August 6, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant