Show query descriptions by dashboard style - #547
Merged
Conversation
BorisTyshkevich
marked this pull request as ready for review
July 29, 2026 13:47
BorisTyshkevich
added a commit
that referenced
this pull request
Jul 29, 2026
…izing-538 Resolutions: - CHANGELOG.md (textual conflict): main cut v0.7.1 and v0.7.2, moving the entries this branch shared with it into those released sections. The grafana-grid@2 bullet moves back under [Unreleased]; main's Caddy no-new-privileges bullet stays under [0.7.2] and the tile-description bullet under [0.7.1]. - src/ui/dashboard.ts (semantic, auto-merged textually): main's #547 "Show dashboard descriptions by style" landed its own `full || report` predicate (`applyTileHeaderStyle`) beside the one this branch added for the resize label. Both ask the same question — is this a fixed-width, one-tile- per-row authored style — so they now share one `isFixedWidthStyle` predicate (CLAUDE.md rule 5: extract when the second consumer appears), renamed from `isVerticalOnlyStyle` because the resize label is only one of its two consumers. #547's mirror-then-reconcile pattern (`tileHeaderStyle` set from `sview.style` before tiles are built) is kept as-is; it is the same shape the resize-label fix needed. Verified on the merged tree: tsc --noEmit clean, npm test 6,622 tests / 201 files with 100% statements and lines, npm run build clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRGDJhCP3SpAHPomJFk6e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Tile descriptions were rendered in every dashboard style, making dense grid and multi-column layouts unnecessarily tall. The query-name tooltip also repeated the name instead of exposing the hidden supporting description.
Impact
Full and Report retain the descriptive two-line header. Grid Tiles and 2/3 columns show only the query name; hovering a described name shows the description, while queries without descriptions have no redundant tooltip. Search behavior and query execution are unchanged.
Validation
npm test— 199 files, 6,598 tests passed; 100% statements/lines, 96.87% branchesnpm run test:e2e— 553 passed across Chromium, Firefox, and WebKit; 8 expected skipsnpm run check:typesgit diff --check