refactor(ship): ChatGPT verifies Fable's own findings, no Sonnet pass - #617
Merged
Merged
Conversation
The ChatGPT-author plan loop fanned out a parallel Sonnet read-only verifier per Fable finding before folding accepted ones into a revision context for ChatGPT -- mirroring the default (Fable-authors) loop's pattern, where that separate fact-check makes sense because Fable there is reviewing ChatGPT's own PR/plan work. But in this loop ChatGPT is the plan's sole author and reviser, and it already performs exactly this kind of live verification unprompted (e.g. looking up an exact npm package version while incorporating a finding about it, observed live on issue #585 phase 0). Fable's raw findings -- explicitly labelled unverified, since Fable is read-only and cannot confirm exact repository/registry state -- now go straight to ChatGPT's revision context instead. ChatGPT verifies each one itself before folding it in, and records anything it rejects under a `## Review responses` section in the plan the same way the default loop's revise agent already does, so nothing is silently dropped even though there's no separate accepted/rejected return value anymore. Removes one Sonnet agent call per finding per pass. Updates review-loops.md and SKILL.md, which documented the removed pattern as a hard rule ("neither ChatGPT nor Fable is a source of truth" / "the workflows return accepted and rejected lists") -- both now describe the ownership-based split: whichever party owns the plan/PR being revised verifies findings against it, never the critic who raised them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwFPT465eDJqYcRa8HGNLz
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The
--planner chatgptplan-author loop (skills/ship/references/chatgpt-plan-author-loop.workflow.mjs) fanned out a parallel Sonnet read-only verifier per Fable finding before folding accepted ones into a revision context for ChatGPT — mirroring the default (Fable-authors) loop's pattern, where that separate fact-check makes sense because Fable there is reviewing ChatGPT's own PR/plan work.But in this loop ChatGPT is the plan's sole author and reviser, and it already performs exactly this kind of live verification unprompted (observed live while running
/ship 585 --planner chatgpt: it looked up the exact current npm package version while incorporating a finding about it). Fable's raw findings — explicitly labelled unverified, since Fable is read-only and cannot confirm exact repository/registry state — now go straight to ChatGPT's revision context instead. ChatGPT verifies each one itself before folding it in, and records anything it rejects under a## Review responsessection in the plan the same way the default loop's revise agent already does, so nothing is silently dropped even though there's no separate accepted/rejected return value anymore.Removes one Sonnet agent call per finding per pass. Updates
review-loops.mdandSKILL.md, which documented the removed pattern as a hard rule ("neither ChatGPT nor Fable is a source of truth" / "the workflows returnacceptedandrejectedlists") — both now describe the ownership-based split: whichever party owns the plan/PR being revised verifies findings against it, never the critic who raised them.skills/ship/tests/*.test.mjs(plainnode --test) is green: 5/5.Checklist
node --testsuite — N/A to product vitest gate)npm test(product coverage gate) — N/A, this only touchesskills/ship/npm run build— N/A, same reasonsrc/core/src/net/src/ui) — N/A, same reason