fix(ship): give chatgpt-review plan-mode reviews pass-aware context - #620
Merged
BorisTyshkevich merged 1 commit intoAug 6, 2026
Merged
Conversation
mode 'plan' built an identical review prompt on every pass, unlike mode 'pr' which already tells ChatGPT to reassess its own earlier findings on later passes. During a live plan-review-loop run (#585 phase 1), ChatGPT re-raised two findings on pass 5 that were already rejected with cited evidence in the plan's own "## Review responses" section on passes 1-3, burning review passes on re-litigation instead of new issues. Pass 2+ now tells ChatGPT it is continuing the same conversation over the same plan, points it at "## Review responses" for previously rejected findings, and asks it to refute the cited evidence rather than restate the original claim. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwFPT465eDJqYcRa8HGNLz
BorisTyshkevich
added a commit
that referenced
this pull request
Aug 6, 2026
Picks up PR #620 (chatgpt-review plan-mode fix, unrelated) so the integration branch tracks main's tip before opening the Phase 1 PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LwFPT465eDJqYcRa8HGNLz
This was referenced Aug 6, 2026
BorisTyshkevich
deleted the
fix/chatgpt-review-plan-revision-pass-context
branch
August 6, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mode === 'plan'inskills/chatgpt-review/scripts/lib/prompt.mjsbuilt an identical review prompt on every pass, with no pass-aware branching — unlikemode === 'pr', which already tells ChatGPT to reassess its own earlier findings on later passes./ship 585.1plan-review-loop run: ChatGPT re-raised two findings on pass 5 that were already rejected with cited repository evidence in the plan's own## Review responsessection on passes 1–3, burning review passes on re-litigation instead of surfacing new issues.## Review responsesfor previously rejected findings, and asks it to explicitly refute the cited evidence rather than restate the original claim — mirroring the existingpr-mode pattern.Test plan
node --test tests/*.test.mjsinskills/chatgpt-review/— 43/43 pass, including new pass-1/pass-2 prompt-content assertions formode: 'plan'.skills/is standalone agent tooling, not part of the main product'snpm test/tsc/coverage gate (verified against rootpackage.jsonscripts) — no product-code impact.🤖 Generated with Claude Code
https://claude.ai/code/session_01LwFPT465eDJqYcRa8HGNLz