Repository navigation
fix(codex): send T3's MCP server as a dotted config key so profile servers stay - #22
Merged
Merged
Conversation
…ne servers stay Codex 0.160 lets a nested mcp_servers table in thread/start config replace every server given on its command line (-c mcp_servers.*), which drops the MCP servers Trellis agent profiles add; a dotted mcp_servers.t3-code key merges. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…keys Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lane T3 follow-up from the Env lane's checks.
Problem
Codex 0.160: when
thread/start(and resume/fork)configcarries a nestedmcp_serverstable, that table replaces every MCP server configured on the app-server's command line (-c mcp_servers.*). Trellis agent profiles add their MCP servers that way, so a Trellis thread on Codex lost them. A dotted key ({"mcp_servers.t3-code": {...}}) merges instead.Change
codexThreadRuntimeParamssends T3's own server as"mcp_servers.t3-code": {url, http_headers}. It is used for start, resume, fork, and rollback resume. The value shape matches Codex's config reference.packages/effect-codex-app-server/src/replay.ts) also leave outmcp_servers.*dotted keys, as they already did for the nested table. Recorded transcripts then still match whatever machine-local MCP endpoint and token a run uses.codex execwithout T3's server.Checks
CodexAdapterV2.test.tsexpects the dotted key, with the Trellis loopback host rewrite, and no nestedmcp_servers.replay.test.tscovers normalization for nested, dotted and absent servers.knip:check,vp check,vpr typecheckandrelease-smokepass.t3tests fail only on the knownCodexInstallationandAcpSessionRuntime.processTreefailures. Package tests fail only on the known desktop libsecret and snapshot file-mode failures (desktop rerun after an Electron install race); client-runtime, relay and mobile pass when run separately.build:desktopfails on the known libsecret helper.🤖 Generated with Claude Code