Repository navigation
Vector index: the engine now builds a hierarchy by default; docs and one test say so - #419
Merged
Merged
Conversation
…cs and one test say so ArcadeData/arcadedb#12616 (engine 26.12.1) makes new LSM vector indexes hierarchical by default. A SQL CREATE INDEX without addHierarchy now agrees with create_vector_index(), and only quantization still differs. The how-to page, the docstring of create_vector_index and test_add_hierarchy_default_agrees_between_sql_and_python name the old default (a flat graph) and failed on the snapshot engine since 2026-11-20, which turns the platform tests of every pull request red. The page says the old default for 26.11.1 and earlier. Closes #418
1 of 3 tasks
…s on The same two tests run on the snapshot engine (a hierarchy by default since ArcadeData/arcadedb#12616) and, in the installed-wheel parity job, on a wheel with engine 26.11.1 (a flat graph from SQL). They now read the engine version through SELECT version(), as test_docs_facets_page.py does, and expect the default of that engine; the page keeps showing the 26.12.1 value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #418
The engine (ArcadeData/arcadedb#12616, release 26.12.1) now builds a hierarchy for a new LSM vector index by default, so a SQL
CREATE INDEX ... LSM_VECTORwithout"addHierarchy"agrees withcreate_vector_index(); onlyquantizationstill differs. This changes:docs/modules/ROOT/pages/how-to/vectors.adoc: the defaults table (the engine default istruefrom 26.12.1 andfalseon 26.11.1 and earlier), the printed output of block 2 (NONE True), and the sentence on how to get the statement's index from the method;create_vector_index;tests/test_vector_sql.pyandtests/test_docs_vectors_page.py: the same two tests also run in the installed-wheel parity job, on a wheel with engine 26.11.1 (DEV_ENGINE: 26.11.1), which still builds a flat graph from SQL. They now read the engine version throughSELECT version(), astest_docs_facets_page.pydoes, and expect the default of the engine they run on; the page keeps showing the 26.12.1 value. The first version of this pull request asserted the new default everywhere and failed that parity job.Checked:
compile()on the two Python files,uvx pre-commit run --fileson the three files (black, isort, ruff and the name check pass). I did not run the two tests locally: they need a wheel built on the snapshot engine, so the platform jobs of this pull request are the check. The two tests are the ones that failed on #417.