Repository navigation
Fix getSizeAsString test by using Locale - #3324
Conversation
Summary of ChangesHello @gramian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the file size formatting logic within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue with getSizeAsString where the output format was dependent on the default Locale. By explicitly using Locale.ENGLISH with String.format, the output is now consistent, which resolves the test failures. I've also suggested a refactoring for the getSizeAsString method to reduce code duplication and improve maintainability.
| if (iSize > TERABYTE) | ||
| return "%2.2fTB".formatted((float) iSize / TERABYTE); | ||
| return String.format(Locale.ENGLISH, "%2.2fTB", (float) iSize / TERABYTE); | ||
| if (iSize > GIGABYTE) | ||
| return "%2.2fGB".formatted((float) iSize / GIGABYTE); | ||
| return String.format(Locale.ENGLISH, "%2.2fGB", (float) iSize / GIGABYTE); | ||
| if (iSize > MEGABYTE) | ||
| return "%2.2fMB".formatted((float) iSize / MEGABYTE); | ||
| return String.format(Locale.ENGLISH, "%2.2fMB", (float) iSize / MEGABYTE); | ||
| if (iSize > KILOBYTE) | ||
| return "%2.2fKB".formatted((float) iSize / KILOBYTE); | ||
| return String.format(Locale.ENGLISH, "%2.2fKB", (float) iSize / KILOBYTE); |
There was a problem hiding this comment.
While the fix to use Locale.ENGLISH is correct, this method has repetitive logic for handling different size units. This can be refactored to improve maintainability by removing code duplication. If the formatting logic needs to change in the future (e.g., precision of the float), it would only need to be updated in one place.
| if (iSize > TERABYTE) | |
| return "%2.2fTB".formatted((float) iSize / TERABYTE); | |
| return String.format(Locale.ENGLISH, "%2.2fTB", (float) iSize / TERABYTE); | |
| if (iSize > GIGABYTE) | |
| return "%2.2fGB".formatted((float) iSize / GIGABYTE); | |
| return String.format(Locale.ENGLISH, "%2.2fGB", (float) iSize / GIGABYTE); | |
| if (iSize > MEGABYTE) | |
| return "%2.2fMB".formatted((float) iSize / MEGABYTE); | |
| return String.format(Locale.ENGLISH, "%2.2fMB", (float) iSize / MEGABYTE); | |
| if (iSize > KILOBYTE) | |
| return "%2.2fKB".formatted((float) iSize / KILOBYTE); | |
| return String.format(Locale.ENGLISH, "%2.2fKB", (float) iSize / KILOBYTE); | |
| final long[] dividers = { TERABYTE, GIGABYTE, MEGABYTE, KILOBYTE }; | |
| final String[] units = { "TB", "GB", "MB", "KB" }; | |
| for (int i = 0; i < dividers.length; i++) { | |
| if (iSize > dividers[i]) { | |
| return String.format(Locale.ENGLISH, "%2.2f%s", (float) iSize / dividers[i], units[i]); | |
| } | |
| } |
🧪 CI InsightsHere's what we observed from your CI run for 975b6f9. 🟢 All jobs passed!But CI Insights is watching 👀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
==========================================
- Coverage 56.63% 56.57% -0.06%
==========================================
Files 1368 1368
Lines 100618 100618
Branches 20486 20486
==========================================
- Hits 56981 56926 -55
- Misses 34512 34566 +54
- Partials 9125 9126 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(cherry picked from commit ae42d73)
… 3.5.5 to 3.5.6 [skip ci] Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.5.5 to 3.5.6. Release notes *Sourced from [org.apache.maven.plugins:maven-surefire-plugin's releases](https://github.com/apache/maven-surefire/releases).* > 3.5.6 > ----- > > 🚀 New features and improvements > ------------------------------- > > * Introduce reportTestTimestamp option and include timestamp for test sets and test cases ([#3261](https://redirect.github.com/apache/maven-surefire/issues/3261)) ([#3302](https://redirect.github.com/apache/maven-surefire/pull/3302)) [`@olamy`](https://github.com/olamy) > > 🐛 Bug Fixes > ----------- > > * Issue [#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_socket at address' is not displayed anymore when using maven.surefire.debug ([#3353](https://redirect.github.com/apache/maven-surefire/issues/3353)) ([#3354](https://redirect.github.com/apache/maven-surefire/pull/3354)) [`@olamy`](https://github.com/olamy) > * Ensure that the statistics filename is calculated only once. ([#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([#3327](https://redirect.github.com/apache/maven-surefire/pull/3327)) [`@olamy`](https://github.com/olamy) > * Add `flakes` attribute to use in `testsuite` report ([#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([#3308](https://redirect.github.com/apache/maven-surefire/pull/3308)) [`@olamy`](https://github.com/olamy) > * [BACKPORT 3.5.x] [[SUREFIRE-2049]](https://issues.apache.org/jira/browse/SUREFIRE-2049) - Fix SHUTDOWN type lost during command serialization. ([#3270](https://redirect.github.com/apache/maven-surefire/issues/3270)) ([#3289](https://redirect.github.com/apache/maven-surefire/pull/3289)) [`@olamy`](https://github.com/olamy) > * fix: null guard for context map ([#3269](https://redirect.github.com/apache/maven-surefire/issues/3269)) ([#3272](https://redirect.github.com/apache/maven-surefire/pull/3272)) [`@olamy`](https://github.com/olamy) > > 👻 Maintenance > ------------- > > * 3.5.x/bug/cherry pick embedded mode its ([#3328](https://redirect.github.com/apache/maven-surefire/pull/3328)) [`@olamy`](https://github.com/olamy) > * Use surefire 3.5.5 by project itself for testing ([#3324](https://redirect.github.com/apache/maven-surefire/pull/3324)) [`@slawekjaranowski`](https://github.com/slawekjaranowski) > * Follow Oracle javadoc guidelines ([#3177](https://redirect.github.com/apache/maven-surefire/pull/3177)) [`@elharo`](https://github.com/elharo) > > 📦 Dependency updates > -------------------- > > * Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 ([#3334](https://redirect.github.com/apache/maven-surefire/pull/3334)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump commons-io:commons-io from 2.21.0 to 2.22.0 ([#3350](https://redirect.github.com/apache/maven-surefire/pull/3350)) @[dependabot[bot]](https://github.com/apps/dependabot) Commits * [`25ea054`](apache/maven-surefire@25ea054) [maven-release-plugin] prepare release surefire-3.5.6 * [`e5f374c`](apache/maven-surefire@e5f374c) Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 * [`dadd55b`](apache/maven-surefire@dadd55b) Issue [#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_soc... * [`39dd250`](apache/maven-surefire@39dd250) Bump commons-io:commons-io from 2.21.0 to 2.22.0 * [`2774273`](apache/maven-surefire@2774273) Ensure that the statistics filename is calculated only once. ([#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([#3327](https://redirect.github.com/apache/maven-surefire/issues/3327)) * [`0d5df8a`](apache/maven-surefire@0d5df8a) 3.5.x/bug/cherry pick embedded mode its ([#3328](https://redirect.github.com/apache/maven-surefire/issues/3328)) * [`04ad9a2`](apache/maven-surefire@04ad9a2) Use surefire 3.5.5 by project itself for testing * [`37e8f69`](apache/maven-surefire@37e8f69) Add `flakes` attribute to use in `testsuite` report ([#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([#3308](https://redirect.github.com/apache/maven-surefire/issues/3308)) * [`a970fef`](apache/maven-surefire@a970fef) Introduce reportTestTimestamp option and include timestamp for test sets and ... * [`e838393`](apache/maven-surefire@e838393) deploy 3.5.x branch to nexus * Additional commits viewable in [compare view](apache/maven-surefire@surefire-3.5.5...surefire-3.5.6) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
…from 3.5.5 to 3.5.6 [skip ci] Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.5.5 to 3.5.6. Release notes *Sourced from [org.apache.maven.plugins:maven-failsafe-plugin's releases](https://github.com/apache/maven-surefire/releases).* > 3.5.6 > ----- > > 🚀 New features and improvements > ------------------------------- > > * Introduce reportTestTimestamp option and include timestamp for test sets and test cases ([#3261](https://redirect.github.com/apache/maven-surefire/issues/3261)) ([#3302](https://redirect.github.com/apache/maven-surefire/pull/3302)) [`@olamy`](https://github.com/olamy) > > 🐛 Bug Fixes > ----------- > > * Issue [#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_socket at address' is not displayed anymore when using maven.surefire.debug ([#3353](https://redirect.github.com/apache/maven-surefire/issues/3353)) ([#3354](https://redirect.github.com/apache/maven-surefire/pull/3354)) [`@olamy`](https://github.com/olamy) > * Ensure that the statistics filename is calculated only once. ([#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([#3327](https://redirect.github.com/apache/maven-surefire/pull/3327)) [`@olamy`](https://github.com/olamy) > * Add `flakes` attribute to use in `testsuite` report ([#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([#3308](https://redirect.github.com/apache/maven-surefire/pull/3308)) [`@olamy`](https://github.com/olamy) > * [BACKPORT 3.5.x] [[SUREFIRE-2049]](https://issues.apache.org/jira/browse/SUREFIRE-2049) - Fix SHUTDOWN type lost during command serialization. ([#3270](https://redirect.github.com/apache/maven-surefire/issues/3270)) ([#3289](https://redirect.github.com/apache/maven-surefire/pull/3289)) [`@olamy`](https://github.com/olamy) > * fix: null guard for context map ([#3269](https://redirect.github.com/apache/maven-surefire/issues/3269)) ([#3272](https://redirect.github.com/apache/maven-surefire/pull/3272)) [`@olamy`](https://github.com/olamy) > > 👻 Maintenance > ------------- > > * 3.5.x/bug/cherry pick embedded mode its ([#3328](https://redirect.github.com/apache/maven-surefire/pull/3328)) [`@olamy`](https://github.com/olamy) > * Use surefire 3.5.5 by project itself for testing ([#3324](https://redirect.github.com/apache/maven-surefire/pull/3324)) [`@slawekjaranowski`](https://github.com/slawekjaranowski) > * Follow Oracle javadoc guidelines ([#3177](https://redirect.github.com/apache/maven-surefire/pull/3177)) [`@elharo`](https://github.com/elharo) > > 📦 Dependency updates > -------------------- > > * Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 ([#3334](https://redirect.github.com/apache/maven-surefire/pull/3334)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump commons-io:commons-io from 2.21.0 to 2.22.0 ([#3350](https://redirect.github.com/apache/maven-surefire/pull/3350)) @[dependabot[bot]](https://github.com/apps/dependabot) Commits * [`25ea054`](apache/maven-surefire@25ea054) [maven-release-plugin] prepare release surefire-3.5.6 * [`e5f374c`](apache/maven-surefire@e5f374c) Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 * [`dadd55b`](apache/maven-surefire@dadd55b) Issue [#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_soc... * [`39dd250`](apache/maven-surefire@39dd250) Bump commons-io:commons-io from 2.21.0 to 2.22.0 * [`2774273`](apache/maven-surefire@2774273) Ensure that the statistics filename is calculated only once. ([#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([#3327](https://redirect.github.com/apache/maven-surefire/issues/3327)) * [`0d5df8a`](apache/maven-surefire@0d5df8a) 3.5.x/bug/cherry pick embedded mode its ([#3328](https://redirect.github.com/apache/maven-surefire/issues/3328)) * [`04ad9a2`](apache/maven-surefire@04ad9a2) Use surefire 3.5.5 by project itself for testing * [`37e8f69`](apache/maven-surefire@37e8f69) Add `flakes` attribute to use in `testsuite` report ([#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([#3308](https://redirect.github.com/apache/maven-surefire/issues/3308)) * [`a970fef`](apache/maven-surefire@a970fef) Introduce reportTestTimestamp option and include timestamp for test sets and ... * [`e838393`](apache/maven-surefire@e838393) deploy 3.5.x branch to nexus * Additional commits viewable in [compare view](apache/maven-surefire@surefire-3.5.5...surefire-3.5.6)
… 3.5.5 to 3.5.6 [skip ci] Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.5.5 to 3.5.6. Release notes *Sourced from [org.apache.maven.plugins:maven-surefire-plugin's releases](https://github.com/apache/maven-surefire/releases).* > 3.5.6 > ----- > > 🚀 New features and improvements > ------------------------------- > > * Introduce reportTestTimestamp option and include timestamp for test sets and test cases ([ArcadeData#3261](https://redirect.github.com/apache/maven-surefire/issues/3261)) ([ArcadeData#3302](https://redirect.github.com/apache/maven-surefire/pull/3302)) [`@olamy`](https://github.com/olamy) > > 🐛 Bug Fixes > ----------- > > * Issue [ArcadeData#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_socket at address' is not displayed anymore when using maven.surefire.debug ([ArcadeData#3353](https://redirect.github.com/apache/maven-surefire/issues/3353)) ([ArcadeData#3354](https://redirect.github.com/apache/maven-surefire/pull/3354)) [`@olamy`](https://github.com/olamy) > * Ensure that the statistics filename is calculated only once. ([ArcadeData#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([ArcadeData#3327](https://redirect.github.com/apache/maven-surefire/pull/3327)) [`@olamy`](https://github.com/olamy) > * Add `flakes` attribute to use in `testsuite` report ([ArcadeData#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([ArcadeData#3308](https://redirect.github.com/apache/maven-surefire/pull/3308)) [`@olamy`](https://github.com/olamy) > * [BACKPORT 3.5.x] [[SUREFIRE-2049]](https://issues.apache.org/jira/browse/SUREFIRE-2049) - Fix SHUTDOWN type lost during command serialization. ([ArcadeData#3270](https://redirect.github.com/apache/maven-surefire/issues/3270)) ([ArcadeData#3289](https://redirect.github.com/apache/maven-surefire/pull/3289)) [`@olamy`](https://github.com/olamy) > * fix: null guard for context map ([ArcadeData#3269](https://redirect.github.com/apache/maven-surefire/issues/3269)) ([ArcadeData#3272](https://redirect.github.com/apache/maven-surefire/pull/3272)) [`@olamy`](https://github.com/olamy) > > 👻 Maintenance > ------------- > > * 3.5.x/bug/cherry pick embedded mode its ([ArcadeData#3328](https://redirect.github.com/apache/maven-surefire/pull/3328)) [`@olamy`](https://github.com/olamy) > * Use surefire 3.5.5 by project itself for testing ([ArcadeData#3324](https://redirect.github.com/apache/maven-surefire/pull/3324)) [`@slawekjaranowski`](https://github.com/slawekjaranowski) > * Follow Oracle javadoc guidelines ([ArcadeData#3177](https://redirect.github.com/apache/maven-surefire/pull/3177)) [`@elharo`](https://github.com/elharo) > > 📦 Dependency updates > -------------------- > > * Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 ([ArcadeData#3334](https://redirect.github.com/apache/maven-surefire/pull/3334)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump commons-io:commons-io from 2.21.0 to 2.22.0 ([ArcadeData#3350](https://redirect.github.com/apache/maven-surefire/pull/3350)) @[dependabot[bot]](https://github.com/apps/dependabot) Commits * [`25ea054`](apache/maven-surefire@25ea054) [maven-release-plugin] prepare release surefire-3.5.6 * [`e5f374c`](apache/maven-surefire@e5f374c) Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 * [`dadd55b`](apache/maven-surefire@dadd55b) Issue [ArcadeData#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_soc... * [`39dd250`](apache/maven-surefire@39dd250) Bump commons-io:commons-io from 2.21.0 to 2.22.0 * [`2774273`](apache/maven-surefire@2774273) Ensure that the statistics filename is calculated only once. ([ArcadeData#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([ArcadeData#3327](https://redirect.github.com/apache/maven-surefire/issues/3327)) * [`0d5df8a`](apache/maven-surefire@0d5df8a) 3.5.x/bug/cherry pick embedded mode its ([ArcadeData#3328](https://redirect.github.com/apache/maven-surefire/issues/3328)) * [`04ad9a2`](apache/maven-surefire@04ad9a2) Use surefire 3.5.5 by project itself for testing * [`37e8f69`](apache/maven-surefire@37e8f69) Add `flakes` attribute to use in `testsuite` report ([ArcadeData#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([ArcadeData#3308](https://redirect.github.com/apache/maven-surefire/issues/3308)) * [`a970fef`](apache/maven-surefire@a970fef) Introduce reportTestTimestamp option and include timestamp for test sets and ... * [`e838393`](apache/maven-surefire@e838393) deploy 3.5.x branch to nexus * Additional commits viewable in [compare view](apache/maven-surefire@surefire-3.5.5...surefire-3.5.6) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
…from 3.5.5 to 3.5.6 [skip ci] Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.5.5 to 3.5.6. Release notes *Sourced from [org.apache.maven.plugins:maven-failsafe-plugin's releases](https://github.com/apache/maven-surefire/releases).* > 3.5.6 > ----- > > 🚀 New features and improvements > ------------------------------- > > * Introduce reportTestTimestamp option and include timestamp for test sets and test cases ([ArcadeData#3261](https://redirect.github.com/apache/maven-surefire/issues/3261)) ([ArcadeData#3302](https://redirect.github.com/apache/maven-surefire/pull/3302)) [`@olamy`](https://github.com/olamy) > > 🐛 Bug Fixes > ----------- > > * Issue [ArcadeData#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_socket at address' is not displayed anymore when using maven.surefire.debug ([ArcadeData#3353](https://redirect.github.com/apache/maven-surefire/issues/3353)) ([ArcadeData#3354](https://redirect.github.com/apache/maven-surefire/pull/3354)) [`@olamy`](https://github.com/olamy) > * Ensure that the statistics filename is calculated only once. ([ArcadeData#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([ArcadeData#3327](https://redirect.github.com/apache/maven-surefire/pull/3327)) [`@olamy`](https://github.com/olamy) > * Add `flakes` attribute to use in `testsuite` report ([ArcadeData#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([ArcadeData#3308](https://redirect.github.com/apache/maven-surefire/pull/3308)) [`@olamy`](https://github.com/olamy) > * [BACKPORT 3.5.x] [[SUREFIRE-2049]](https://issues.apache.org/jira/browse/SUREFIRE-2049) - Fix SHUTDOWN type lost during command serialization. ([ArcadeData#3270](https://redirect.github.com/apache/maven-surefire/issues/3270)) ([ArcadeData#3289](https://redirect.github.com/apache/maven-surefire/pull/3289)) [`@olamy`](https://github.com/olamy) > * fix: null guard for context map ([ArcadeData#3269](https://redirect.github.com/apache/maven-surefire/issues/3269)) ([ArcadeData#3272](https://redirect.github.com/apache/maven-surefire/pull/3272)) [`@olamy`](https://github.com/olamy) > > 👻 Maintenance > ------------- > > * 3.5.x/bug/cherry pick embedded mode its ([ArcadeData#3328](https://redirect.github.com/apache/maven-surefire/pull/3328)) [`@olamy`](https://github.com/olamy) > * Use surefire 3.5.5 by project itself for testing ([ArcadeData#3324](https://redirect.github.com/apache/maven-surefire/pull/3324)) [`@slawekjaranowski`](https://github.com/slawekjaranowski) > * Follow Oracle javadoc guidelines ([ArcadeData#3177](https://redirect.github.com/apache/maven-surefire/pull/3177)) [`@elharo`](https://github.com/elharo) > > 📦 Dependency updates > -------------------- > > * Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 ([ArcadeData#3334](https://redirect.github.com/apache/maven-surefire/pull/3334)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump commons-io:commons-io from 2.21.0 to 2.22.0 ([ArcadeData#3350](https://redirect.github.com/apache/maven-surefire/pull/3350)) @[dependabot[bot]](https://github.com/apps/dependabot) Commits * [`25ea054`](apache/maven-surefire@25ea054) [maven-release-plugin] prepare release surefire-3.5.6 * [`e5f374c`](apache/maven-surefire@e5f374c) Bump org.fusesource.jansi:jansi from 2.4.2 to 2.4.3 * [`dadd55b`](apache/maven-surefire@dadd55b) Issue [ArcadeData#2613](https://redirect.github.com/apache/maven-surefire/issues/2613) Debugging failsafe tests: Message 'Listening for transport dt\_soc... * [`39dd250`](apache/maven-surefire@39dd250) Bump commons-io:commons-io from 2.21.0 to 2.22.0 * [`2774273`](apache/maven-surefire@2774273) Ensure that the statistics filename is calculated only once. ([ArcadeData#3326](https://redirect.github.com/apache/maven-surefire/issues/3326)) ([ArcadeData#3327](https://redirect.github.com/apache/maven-surefire/issues/3327)) * [`0d5df8a`](apache/maven-surefire@0d5df8a) 3.5.x/bug/cherry pick embedded mode its ([ArcadeData#3328](https://redirect.github.com/apache/maven-surefire/issues/3328)) * [`04ad9a2`](apache/maven-surefire@04ad9a2) Use surefire 3.5.5 by project itself for testing * [`37e8f69`](apache/maven-surefire@37e8f69) Add `flakes` attribute to use in `testsuite` report ([ArcadeData#3306](https://redirect.github.com/apache/maven-surefire/issues/3306)) ([ArcadeData#3308](https://redirect.github.com/apache/maven-surefire/issues/3308)) * [`a970fef`](apache/maven-surefire@a970fef) Introduce reportTestTimestamp option and include timestamp for test sets and ... * [`e838393`](apache/maven-surefire@e838393) deploy 3.5.x branch to nexus * Additional commits viewable in [compare view](apache/maven-surefire@surefire-3.5.5...surefire-3.5.6)
What does this PR do?
Use
format(Locale,...)instead offormattedingetSizeAsStringFielUTtil.Motivation
Fixes the getFilesizeAsString test.
Checklist
mvn clean packagecommand