Skip to content

Dont present CAN items if CAN is not present in hwdef #151

Description

@Hwurzburg

This causes a build error

Replicate:

  1. Any board without CAN
  2. Click on Rangefinders twice to remove all of them

this will fail since the first click enables all rangefinders, including DroneCAN, which ticks the DroneCAN box, next click removes all Rangefinders but does not uncheck the DroneCAN causes a build failure(which is generally desired behavior since we cant know if a box with driving dependencies is or is not desired)

solutions:
Best: don't present any CAN related options anywhere if the hwdef for the board does not have a "CAN1" define
Easiest: clicking a partially filled section, first REMOVES all the selections, next click Adds all, instead of the other way around...

btw, I have not found another feature that depends on onboard hardware(there may be and I don't recognize it)....I thought ENET might, but currently we have no build option that depends on having that on board...and including sensor drivers for missing onboard sensors might waste space but does not cause a build error

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions