Cmdlets for ClusterTestFailover, ClusterTestFailoverCleanup, ClusterUnplannedFailover, ClusterApplyRecoveryPoint, ClusterCommitFailover by riyanshpal · Pull Request #39 · AsrOneSdk/azure-powershell

riyanshpal · 2025-03-17T07:12:10Z

Description

Checklist

Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
SHOULD make the title of PR clear and informative, and in the present imperative tense.
SHOULD update ChangeLog.md file(s) appropriately
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT introduce breaking changes in Az minor release except preview version.
SHOULD NOT adjust version of module manually in pull request

riyanshpal · 2025-03-18T09:03:21Z

+        [Parameter(
+            ParameterSetName = ASRParameterSets.ByObject,
+            Mandatory = false)]
+        public List<string> NodeRecoveryPoints { get; set; }


Add validation to check nodeRecoveryPoints.

Added the null check, will add ArmId validations in next release.

vidyadharijami · 2025-03-18T10:27:35Z

        }
+
+        /// <summary>
+        ///     Starts Unplanned Failover


Cluster Unplanned.

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:28:12Z

+        }
+
+        /// <summary>
+        ///     Starts Test Failover


Cluster Test Failover. Similarly for Input as well

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:28:50Z

+        }
+
+        /// <summary>
+        ///     Starts Test Failover Cleanup


Change across all calls

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:32:03Z

+                ProviderSpecificDetails = new ApplyClusterRecoveryPointProviderSpecificInput()
+            };
+
+            if (LatestProcessedRecoveryPoints && ClusterRecoveryPoint == null)


Can you add this. for all parameter inputs across this file

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:36:43Z

+        /// <returns> List of node recovery points.</returns>
+        private List<string> UpdateNodeRecoveryPoints()
+        {
+            List<string> clusterProtectedItemIds = ReplicationProtectionCluster.ClusterProtectedItemIds.ToList();


Add a null check for ReplicationProtectionCluster.ClusterProtectedItemIds

Does it is even possible that cluster has no nodes?

Yes, we create cluster and then user need to use this cluster for enable protection

vidyadharijami · 2025-03-18T10:37:54Z

+                node =>
+                {
+                    List<RecoveryPoint> recoveryPoints = this.RecoveryServicesClient.GetAzureSiteRecoveryRecoveryPoint(
+                    fabricName,


Correct indentation

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:43:17Z

+    /// <summary>
+    ///    Starts a test failover operation.


Cluster test failover

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:45:01Z

+
+            List<string> nodeRecoveryPointsList = nodeRecoveryPoints.ToList();
+            return nodeRecoveryPointsList;
+        }


Let's move these to Utilities class as it's used in 3 different cmdlets

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:45:26Z

+{
+
+    /// <summary>
+    ///    Starts a unplanned failover operation.


Cluster unplanned

Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:45:52Z

+        }
+
+        /// <summary>
+        ///     Starts replication protected clustrer unplanned failover.


Ack, updating in next revision.

vidyadharijami · 2025-03-18T10:46:27Z

+
+
+            List<string> nodeRecoveryPointsList = nodeRecoveryPoints.ToList();
+            return nodeRecoveryPointsList;


Same as other comment

Ack, updating in next revision.

vidyadharijami · 2025-03-19T12:03:32Z

+            {
+                return null;
+            }
+        }


Remove as per latest merge

vidyadharijami · 2025-03-19T12:09:45Z

+# Start-AzRecoveryServicesAsrApplyClusterRecoveryPoint
+
+## SYNOPSIS
+Changes a recovery point for a failed over repliction protection cluster before committing the failover operation


replication

riyanshpal force-pushed the dev/riyanshpal/SharedDisk branch from 77ba91e to bb860c8 Compare March 17, 2025 10:15

riyanshpal commented Mar 18, 2025

View reviewed changes

vidyadharijami reviewed Mar 18, 2025

View reviewed changes

vidyadharijami requested changes Mar 18, 2025

View reviewed changes

create cmdlets

898fc48

riyanshpal force-pushed the dev/riyanshpal/SharedDisk branch from b2c0fb0 to 898fc48 Compare March 19, 2025 11:56

vidyadharijami approved these changes Mar 19, 2025

View reviewed changes

address comments

f1a2295

vidyadharijami merged commit ebc6ed3 into dev/vijami/SharedDiskFinalChanges Mar 19, 2025



		List<string> nodeRecoveryPointsList = nodeRecoveryPoints.ToList();
		return nodeRecoveryPointsList;

Conversation

riyanshpal commented Mar 17, 2025

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants