Can't disable `min_java` version validation

[ykrasik]

Hi,

Thanks for this library.

I ran into an issue when bundling a Java app using JavaPackager.
In my Gradle script I'm specifying the JavaPackager.jrePath as jrePath = new File(System.properties['java.home']). I'm bundling the app with the JRE that comes with the JDK. However, the release file of my JDK (1.8) is not located inside the jre folder which gets bundled, but it sits as a child of the jdk folder - see below.

jdk1.8.0_271
|-> release
|-> jre    <- this is what gets bundled
    |-> no release file

This causes the bundled jre to be considered incompatible by this code.

Currently, there is no way to completely disable this version validation, as even setting the min_java to 0 or leaving it unset causes the validation to run (and fail). For the case of bundling a JRE, this validation should be turned off.

[keastrid]

I've pushed a potential fix, please give it a try.

check_main_class must be disabled, and the jre path must point to a valid jvm.dll.

[ykrasik]

Thanks! I'm not running this directly, but through JavaPackager. I'll wait for a new version of JavaPackager to be released and let you know.

[ykrasik]

Tested it, it works for me.
I think the author of JavaPackager is waiting for a new officially released version of Why in order to incorporate it into the next version of JavaPackager (See the issue)

P.S.
There's a small optimization that can be done where the compatible_java_version check can be skipped completely if min_java_ver == 0, since compatible_java_version does a few file system access operations skipping it may save a few milliseconds.

[keastrid]

1.1.2 released. Thanks for the issue report!

There are probably some optimizations to be made, but I'd rather not touch the path finding part as its difficult to test - there were some incomprehensible JVM crashes due to how Windows loads DLLs.