fix(mobile): restore left nav drawer swipe on the feed - #14483
Merged
Merged
Conversation
The For You/Latest swipe pager (#14473) swallowed the horizontal swipe that opens the left nav drawer, and the drawer's own full-width native swipe competed with the pager — so a right-swipe on Latest opened the drawer instead of paging, and arbitration with track tiles was flaky. - Disable the drawer's native swipe while the feed is focused and the drawer is closed (re-enabled when open so swipe-to-close still works), leaving the pager as the sole owner of horizontal paging. - Add a rightward-only pan on the For You page that opens the drawer, composed simultaneously with the pager's native gesture so fast flings aren't claimed by the pager before the pan activates. Result: For You right-swipe opens the drawer (fast or slow, including from a track tile); For You left-swipe and Latest right-swipe page between tabs as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
dylanjeffers
added a commit
that referenced
this pull request
Sep 24, 2026
…ical scrolls (#14601) ## Problem Vertical scrolls with some sideways drift either do nothing or peek a screen/drawer and snap back. Most noticeable on Weekly Rotation, but it affects every nested screen and the root tabs. Three full-screen horizontal recognizers compete with the list's scroll: 1. **Nested screens** — since #14205 (`animation: 'simple_push'` + `customAnimationOnGesture`), react-native-screens uses its own `RNSPanGestureRecognizer` for full-screen swipe-back. Upstream `gestureRecognizerShouldBegin:` has no direction test, and once it begins it refuses to run alongside the scroll view's pan. A drag whose first ~10pt has any rightward component gets claimed as a back gesture. Before #14205 iOS 26 used Apple's `interactiveContentPopGestureRecognizer`, which yields to scroll views — that's the "it used to work" state. 2. **Root tabs** — the drawer navigator's pan spanned the full screen (`swipeEdgeWidth: SCREEN_WIDTH`) with hardcoded 5pt/5pt thresholds, so it won any touch that moved sideways first. 3. **Feed / For You** — the drawer-opener pan from #14483 had no `failOffsetY`, so 20pt of rightward drift anywhere in a long vertical drag opened the drawer. ## Changes - **`patches/react-native-screens+4.18.0.patch`** *(native — needs an App Store release, not OTA)*: `RNSPanGestureRecognizer` may only begin on a committed horizontal drag — ≥5pt toward dismissal and ≥2× the cross-axis travel — evaluated once at the pan's activation threshold. Clean horizontal swipes still pop; anything diagonal stays with the scroll view. - **`useOpenDrawerGesture`** *(OTA-able)*: one direction-locked rightward pan (`activeOffsetX 20`, `failOffsetY ±12`) that opens the left drawer from mid-screen. Used by Feed (replacing its inline pan) and wrapped around every tab's stack in `AppTabScreen`, gated to root + focused + not-now-playing. - **`AppDrawerScreen`** *(OTA-able)*: the navigator's own swipe is kept to a 40pt left edge; swipe-to-close is unaffected (`swipeEdgeWidth` only applies while closed). ## Verification (iOS simulator, Release builds, iPhone 17 Pro / iOS 26.5) Reproduced with a synthetic "thumb-arc" drag on the Weekly Rotation page — 16ms samples starting ~15° from horizontal for the first ~13pt, then straightening to vertical — starting on a loaded tile: | Drag | Unpatched | This branch | |---|---|---| | Thumb-arc | **zero scroll**; header icon circles vanish (interactive pop began and snapped back) | scrolls ~3 tiles | | 30° fine-grained diagonal | ~185pt, no fling | ~310pt with fling | | Fast coarse diagonal | scrolls | scrolls | Also on this branch: Feed Latest ⇄ For You paging, mid-screen drawer open on For You and Trending, drawer swipe-close, Track back-swipe, and diagonal scrolls on Feed/Trending/Track all behave. Fast drags never show the bug on either build (both recognizers cross their thresholds in one event and the scroll view wins the tie); it's the slow curved start that gets claimed. ## Notes - Debug simulator builds abort on `react_native_assert(attempts < 1024)` in `ShadowTree::commit` (via Reanimated's mount hook) when touching tiles — unrelated to this change, but it makes Debug useless for testing this; use Release. - Xcode 27 refuses the pods with deployment targets < 15; that needs a `post_install` bump in the Podfile and will come separately. - `Podfile.lock` drift from `pod install` is intentionally not included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The For You / Latest swipe pager (#14473) wrapped the feed in a
PagerView, which swallowed the horizontal swipe that opens the left nav drawer. The drawer's own full-width native swipe (swipeEdgeWidth: SCREEN_WIDTH) also competed with the pager, so:Changes
setGesturesDisabled), re-enabled once the drawer is open so swipe-to-close still works, and restored on blur. This leaves the pager as the sole owner of horizontal paging.Gesture.Simultaneouswith the pager's native gesture so fast flings aren't claimed by the pager before the pan activates.Behavior
🤖 Generated with Claude Code