This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Conversation
added 7 commits
May 26, 2022 15:32
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
added 2 commits
May 27, 2022 09:43
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
1 similar comment
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
…ile hover and active state
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
1 similar comment
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
dylanjeffers
approved these changes
May 27, 2022
| return ( | ||
| <div className={styles.tippers} onClick={handleClick}> | ||
| {tippers.slice(0, NUM_FEED_TIPPERS_DISPLAYED).map((tipper, index) => ( | ||
| <div key={`tipper-${tipper.user_id}`} className={styles.tipperName}> |
Contributor
There was a problem hiding this comment.
i think tipper.user_id is sufficient
Contributor
Author
There was a problem hiding this comment.
slightly afraid that the user id is used somewhere else on the page
Collaborator
|
Preview this change https://demo.audius.co/sd-tip-qa |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix feed tip tile and other tipping QA issues
what was fixed?
Dragons
n/a
How Has This Been Tested?
local agains stage
How will this change be monitored?
n/a