This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Repository navigation
[C-2680] Attribution Modal - #3778
Merged
Merged
Conversation
amendelsohn
requested review from
a team and
sliptype
and removed request for
a team
July 21, 2023 00:15
Collaborator
|
Preview this change https://demo.audius.co/amendel-attribution-modal-form |
sliptype
approved these changes
Jul 21, 2023
sliptype
left a comment
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Super clean component structure and styles
| border-radius: 8px; | ||
| border: 1px solid var(--neutral-light-8); | ||
| background: var(--neutral-light-10); | ||
| text-transform: capitalize; |
Contributor
There was a problem hiding this comment.
The designs don't have this text-transform from what I can tell
| @@ -0,0 +1,57 @@ | |||
| .row { | |||
Contributor
There was a problem hiding this comment.
I'm a fan of this but we could generalize it even further by putting these into their own file, like common classes
| defaultSelected={derivativeWorks} | ||
| // @ts-ignore boolean support works | ||
| options={derivativeWorksValues} | ||
| // @ts-ignore |
Contributor
There was a problem hiding this comment.
Pretty annoying that we have to do this
Contributor
Author
There was a problem hiding this comment.
Yeah it's fixable but involves rewriting a bunch of stuff I think. I tried fooling with the types, but we'd have to ts-ignore in the SegmentedControl component instead. Maybe better? idk
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 688750 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.dev | View secret |
| 688750 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.prod | View secret |
| 2460749 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.prod | View secret |
| 688750 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.stage | View secret |
| 2416684 | Generic High Entropy Secret | 0c5438f | packages/mobile/.env.stage | View secret |
| 688750 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.dev | View secret |
| 688750 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.prod | View secret |
| 2460749 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.prod | View secret |
| 688750 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.stage | View secret |
| 2416684 | Generic High Entropy Secret | 0c5438f | packages/web/.env/.env.stage | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Collaborator
|
Preview this change https://demo.audius.co/amendel-attribution-modal-form |
dharit-tan
pushed a commit
that referenced
this pull request
Jul 24, 2023
audius-infra
pushed a commit
that referenced
this pull request
Jul 29, 2023
[5e99303] Add favorite test and fix aria-label (#3817) Raymond Jacobson [ccc32ce] [C-2908 C-2744] fix desktop follow button (#3816) Dylan Jeffers [c0679c3] [PAY-1660] Fix layout issues with TrackTile socials row with a lot of stats (#3815) Randy Schott [089a9e6] Pin stripe package versions (#3813) Reed [a281267] [C-2774] Update upload inputs (#3806) Dylan Jeffers [f504ef9] [C-2901] Fix menu types (#3811) Dylan Jeffers [cb9a385] [C-2905] Update Text types and props to camelCase (#3810) Kyle Shanks [027b3a5] [PAY-1624] Implement Purchase modal (#3808) Randy Schott [deadb5f] [C-2902] Update the upload forms to use the typography component (#3809) Kyle Shanks [039c951] [C-801] Fix oauth nodes (#3807) Raymond Jacobson [c3765c7] Update typography component to use classnames (#3805) Kyle Shanks [cab0a3e] Switch to Stripe package instead of script (#3798) Reed [a84126f] [C-2890] Add first version of a typography component to web (#3796) Kyle Shanks [4addddc] Fix mobile prem-content drawer unlocking margin (#3804) Reed [233b585] [C-2857] Remove get blocknumber (#3802) Dylan Jeffers [d113bdb] Prepare for 1.5.34 full app release (#3801) Dylan Jeffers [2f09db4] [C-2887] Fix collection button widths (#3800) Dylan Jeffers [8158e10] [PAY-1655] Add ColorValue prop to Text component (#3799) Reed [fe4bc6a] Revert cacheActions.add thunk (#3797) Dylan Jeffers [2370bbe] [PAY-1650] Update play/preview buttons on track details to use HarmonyButton (#3795) Randy Schott [3579dc2] [PAY-1651] Implements Harmony Buttons (#3794) Randy Schott [5af77ec] [C-2886] Improve cache performance (#3792) Dylan Jeffers [6fb78f1] [PAY-1587] Mobile USDC Purchase Drawer Skeleton (#3793) Reed [1277a41] [C-2883] Migrate confirmer to common (#3788) Dylan Jeffers [ce2548e] [plat-1111] add usdc purchase seller and buyer notifications (#3770) sabrina-kiam [bc04f52] Fix mobile LockedStatusBadge padding (#3790) Reed [8943078] [C-2680] Attribution Modal (#3778) Andrew Mendelsohn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature Flags
UPLOAD_REDESIGN_ENABLED