Repository navigation
fix: weekly rotation browser push, Slack title escaping, comment cleanup - #97
Merged
Merged
Conversation
…t devices The browser push was behind shouldSendPushNotification, which requires a mobile device, so web-only listeners never got it. Send it first, then gate only the mobile push. Removes the devices.length check that could never hit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A title containing >, < or & broke the <url|title> link markup in the digest. Escape them per Slack's mrkdwn rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shorten comments added with the trending digest, General inbox and weekly rotation changes, and use a plain hyphen in the digest's track lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldSendPushNotification, which requires a mobile device, so web-only listeners never got it. The browser push now runs first, only the mobile push is gated, and the unreachabledevices.length === 0check is removed. The no-devices test now asserts the browser push is sent.>,<or&broke the<url|title>markup. Titles are now escaped, with a test.Comment cleanup: shortened comments added in #91-#94 and swapped the em-dash in digest lines for a hyphen.
Tests: trending-challenge-rewards jest (13 passed) and tsc. notifications
tsc --noEmitand eslint on touched files. The notifications jest mapping test was not run locally because it needs discovery/identity template DBs and redis, and CI doesn't run it.🤖 Generated with Claude Code