Skip to content

LuckPerm: keep contexts active after reload of groups - #2186

Merged
sgdc3 merged 14 commits into
AuthMe:masterfrom
garagepoort:master
Aug 21, 2021
Merged

sgdc3 merged 14 commits into
AuthMe:masterfrom
garagepoort:master

Conversation

@garagepoort

Copy link
Copy Markdown
Contributor

We noticed that AuthMe removes the contexts set by luckperm if we enable the option: enablePermissionCheck
This means that after authentication a user might get a group that should not be active.

For example a user is given group: "Titan" with context "Server=Classic"
The user logs in on server "Other".
Because AuthMe, removes and adds the groups the context is lost.
I created this PR to keep the context after reloading the groups.

@sgdc3

sgdc3 commented Nov 22, 2020

Copy link
Copy Markdown
Member

Looks good to me 👍

@sgdc3
sgdc3 requested a review from ljacqu November 22, 2020 13:15
@garagepoort

Copy link
Copy Markdown
Contributor Author

@sgdc3 @ljacqu
not to sound impatient but will this get merged?

@sgdc3

sgdc3 commented Apr 4, 2021

Copy link
Copy Markdown
Member

@ljacqu @games647 @hex3l can somebody review this too please?

@garagepoort

Copy link
Copy Markdown
Contributor Author

hey @sgdc3
My hopes are not too high. But will this get merged?

@sgdc3

sgdc3 commented Aug 6, 2021

Copy link
Copy Markdown
Member

@ljacqu @games647 @hex3l any opinion on this?

@sgdc3
sgdc3 merged commit d969d31 into AuthMe:master Aug 21, 2021
@sgdc3

sgdc3 commented Aug 21, 2021 •

Copy link
Copy Markdown
Member

@garagepoort sorry for the delay, I wanted to wait for a review by the other contributors but they seems to be busy atm 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants