Repository navigation
Execute simple check before enable BungeeCord hook. - #2572
Merged
Merged
Conversation
TuxCoding
requested changes
Jul 4, 2022
Member
There was a problem hiding this comment.
Good idea, but maybe we should also add an entry to the SettingsWarner, so that we don't disable functionality for the user without telling them the reason. There might be cases where people actually forget to turn on this BungeeCord setting (the spigot.yml one).
TuxCoding
approved these changes
Jul 6, 2022
TuxCoding
left a comment
TuxCoding
left a comment
Member
There was a problem hiding this comment.
!LGTM
Although this potentially break Velocity support. However we don't support Velocity officially, so I think it's fine.
Member
|
Could you squash them into a single commit and then it's good to go. |
This commit added a simple check that check spigot.yml -> settings.bungeecord status by using AuthMe built-in method bukkitService.isBungeeCordConfiguredForSpigot() and disable hook if it enabled and not behind an BungeeCord proxy. Register plugin message channel without BungeeCord proxy will allow attacker send fake login payload to treat AuthMe login with Plugin Message for him and bypass the user login. This commit also updated SettingsWarner for new behavior.
Contributor
Author
|
@games647 It's squashed to one single commit now ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added a simple check that check spigot.yml -> settings.bungeecord status by using AuthMe built-in method bukkitService.isBungeeCordConfiguredForSpigot() and disable hook if it enabled and not behind an BungeeCord proxy.
Register plugin message channel without BungeeCord proxy will allow attacker send fake login payload to treat AuthMe login with Plugin Message for him and bypass the user login.
Fixed:
#2571
#2559