[manduinca]

Written with LLM assistance: the Weir rules and their tests were drafted with an LLM. The approach, the corpus validation and the final wording are mine, and I've reviewed every line.

Issues

Closes #1070.

Description

tenant (a renter) gets written where tenet (a principle) is meant: "the core tenants of our design".

This adds a grouped TenantTenet rule (singular and plural children) that fires only when tenant/tenants follows a principle-sense adjective — core, central, fundamental, basic, guiding, cardinal, underlying, foundational, defining — and is followed by of or is. Phrases like of the building are excluded through a word list of places.

The narrow shape is the point, and it comes from data rather than taste. I pulled 2,086 real sentences containing tenant/tenants from GitHub issues and Wikipedia and ran the rule over them: 30 hits, 29 of them the actual mistake. The one false positive is a Japanese shopping centre ("the core tenant of Tamagawa Takashimaya Shopping Center").

The obvious wider rule does much worse on the same sample. Gating on "adjective + non-noun", which is where #3822 ended up, would have flagged around 20 legitimate uses: "its core tenant was a hotel", "Central tenants are in scope", "with two core tenants, Armstrong Marine and Winter Custom Yachts".

main and key are deliberately left out. In that corpus, 19 of their 23 of/is uses are stadiums, malls and office buildings — "The main tenants of the stadium are…". That does cost the rule the "main tenants of many religions" example from the issue; I'd rather miss it than flag every arena in Wikipedia.

Known misses, all on purpose: sentence-final "a core tenant." (nothing follows to disambiguate) and "core tenants from day 1".

Demo

$ harper-cli lint --only TenantTenet "These are the core tenants of our design."
Malapropism: Did you mean `tenets`? A `tenant` rents a place; a `tenet` is a principle.

$ harper-cli lint --only TenantTenet "The core tenant isolation logic lives here."
(no lints)

How Has This Been Tested?

42 tests across the two .weir files, covering true positives, the multi-tenancy false positives, real-estate uses, casing and sentence-final forms. cargo test -p harper-core passes, 6,559 tests, including curated_default_config_lists_every_registered_rule after adding the entry to default_config.json.