Skip to content

inconsistencies on L2Block-logs #10522

Description

@FilipHarald

With #10210 and/or #10308 the API on L2Block for getting logs changed. - I'm sure it's for good reasons, but with the current implementation there are now inconsistencies between the txEffect.privateLogs and txEffect.unencryptedLogs.

The former is an array, and the latter is an object (with the logs/array in .functionLogs).

Activity

  1. FilipHarald commented on Dec 9, 2024

    @FilipHarald
    ContributorAuthor

    Also, @LeilaWang and @rahul-kothari it would have been great to have this update under "breaking changes" in the release notes here: #10282
    (I do see them being mentioned further down the list)

  2. LeilaWang commented on Dec 12, 2024

    @LeilaWang
    Contributor

    Sorry for the confusion! We will also change the unencrypted logs to be an array. But since there are many changes happening on the public side, this has been given slightly lower priority. But this inconsistency is just temporary, and we will make sure to add it to breaking changes next time. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    from-communityThis originated from the community :)help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions