Now that we are performing nonce discovery inside aztec-nr we have multiple places in which we need to invoke this function. Ideally we'd simply remove the top-level unconstrained compute_note_hash_and_nullif fn, have the macros inject a contract library method with the note::discovery::ComputeNoteHashAndNullifier signature and just use that everywhere. We could also delete the utility in notes/utils.nr since it just adds more calls back and forth, resulting in making it hard to follow what's going on.
This would also be a good opportunity to make sure we're not trusting the contract to perform correct siloing of note hashes and instead do it ourselves in PXE.
Now that we are performing nonce discovery inside aztec-nr we have multiple places in which we need to invoke this function. Ideally we'd simply remove the top-level unconstrained
compute_note_hash_and_nulliffn, have the macros inject a contract library method with thenote::discovery::ComputeNoteHashAndNullifiersignature and just use that everywhere. We could also delete the utility innotes/utils.nrsince it just adds more calls back and forth, resulting in making it hard to follow what's going on.This would also be a good opportunity to make sure we're not trusting the contract to perform correct siloing of note hashes and instead do it ourselves in PXE.