Feature: Add a compares field to NoteGetterOptions and NoteViewerOptions to fetch > or < field value notes

[harshnambiar]

Currently, selects field fetches notes where the given value matches the concerned index value for a note (==). We could have a compares field inside those 2 structures that takes similar care of the (>), (<), (>=), and (<=) conditions. This would allow the end dev to not have to write a filter method for the same.

[LHerskind]

The get_notes function in note_getter.nr applies a the check_note_fields function which is directly checking if two values matches.

This could be altered such that the select is passing a closure instead. So something like

NoteGetterOptions::new()
  .select(0, points as Field)
  .select(1, secret)
  .select(2, account.to_field())

Could be replaced with something like:

NoteGetterOptions::new()
  .select(|note: Note|{
    (note.points == points) & 
    (note.secret == secret) &
    (note.account == account)
  })

This way, it is easy to change such that it could use >= or the like.

Implementation wise, the closure should be defined something along the lines of fn[Env](note:Note) -> bool

[LHerskind]

Noticed in the note_getter.nr file that the selects are passed along to the PXE when using the oracle to fetch the note. So we want it to be able to convey enough information to the PXE so it can return the right notes. Likely better extension to then add a comparator to the selects such that it is (index, comparator, value). This is very easy to convey to the PXE.

[nventuro]

This would involve changing selectNotes in pick_notes.js so that it doesn't just check for equality, right?

[LHerskind]

This would involve changing selectNotes in pick_notes.js so that it doesn't just check for equality, right?

Exactly. @sklppy88 will pick it up now.

• pick_notes.ts
• note_getter.nr
• note_getter_options.nr