Skip to content

refactor(AztecMacro): Improve detection of compute_note_hash_and_nullifier #4647

Closed

Description

@nventuro

#4610 autogenerates fn compute_note_hash_and_nullifier unless the user has already provided an implementation. However, we're checking for the user to provide an implementation with the exact right number and type of parameters. If they e.g. forget one, or get a type wrong, we'll stil try to declare our autogenerated version, resulting in a duplicate definition error.

We should emit more useful errors in this scenario, e.g. point out that the user-defined function is wrong.

Activity

  1. changed the title [-]Improve detection of compute_note_hash_and_nullifier[/-] [+]refactor(AztecMacro): Improve detection of compute_note_hash_and_nullifier[/+] on Mar 8, 2024
  2. nventuro commented on Jun 2, 2025

    @nventuro
    ContributorAuthor

    Stale - this fn is now a contract library method, and there's no need for a user to provide it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions