Skip to content

refactor(Misc): Pad block transactions in runCircuits function and not before #5357

Closed
#5532
#5482
Closed
refactor(Misc): Pad block transactions in runCircuits function and not before#5357
#5532
#5482
Assignees
benesjan

Description

@benesjan
benesjan
opened on Mar 21, 2024

We pad txs with empty ones because circuits require num txs on inputs to be constant. Currently we do that higher up in the function call stack instead of doing that when it's really needed. Ensure that the txs are padded as late as possible (in runCircuits function).

Note: Look for "TODO(#5357)" in the codebase.

Activity

  1. github-project-automation
    added this to A3on Mar 21, 2024
  2. github-project-automation
    moved this to Todo in A3on Mar 21, 2024
  3. LHerskind
    changed the title [-]Pad block transactions in runCircuits function and not before[/-] [+]refactor(Misc): Pad block transactions in runCircuits function and not before[/+] on Mar 21, 2024
  4. benesjan
    self-assigned this
    on Mar 27, 2024
  5. benesjan
    closed this as completedin #5482on Apr 3, 2024
  6. benesjan
    added a commit that references this issue on Apr 3, 2024

    refactor: pad when needed and not sooner (#5482)

    e928c33
  7. github-project-automation
    moved this from Todo to Done in A3on Apr 3, 2024
  8. rahul-kothari
    added a commit that references this issue on Apr 9, 2024

    chore(master): Release 0.33.0 (#5532)

    4c5579d
  9. AztecBot
    added a commit that references this issue on Apr 10, 2024

    chore(master): Release 0.33.0 (#5532)

    adab84d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions